Skip to content

Document hooks in readme #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Document hooks in readme #28

merged 3 commits into from
Mar 7, 2019

Conversation

jordaneb
Copy link
Member

@jordaneb jordaneb commented Mar 7, 2019

Hooks are currently undocumented but can be very handy; particularly failure hooks. Here's some basic documentation for them so that it's easier to discover them!

@j4mie
Copy link
Member

j4mie commented Mar 7, 2019

This is great but there's a really important detail that we should add - the creation hook happens in the save of the Job model, so will run in the process that creates the job (ie usually the web server process). The failure hook runs in the worker process (if the job fails).

@j4mie j4mie merged commit ddf9450 into master Mar 7, 2019
@j4mie j4mie deleted the hooks-documentation branch March 7, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants