Update Django and python support #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to Travis matrix
…go-and-python-support
RealOrangeOne
suggested changes
Nov 21, 2019
| python: | ||
| - '3.4' | ||
| - '3.6' | ||
| - '3.7' |
There was a problem hiding this comment.
3.6 is stull used a lot, and 3.5 for that matter. Can we add tests for those?
django_dbq/models.py
Outdated
| FAILED = 'FAILED' | ||
| COMPLETE = 'COMPLETE' | ||
|
|
||
| STATES = [ |
There was a problem hiding this comment.
Can we make this backwards compatible with how it used to work, ie set STATES = State, and the choices as STATES_CHOICES or something?
RealOrangeOne
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uuidfielddjango-model-utilssimplesignalsbecause we actually leverage the entire package and it does seem to do quite a lot of nice stuff on its own.