Skip to content

fix #479 getNodeState with vertical nodes #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 11, 2019
Merged

fix #479 getNodeState with vertical nodes #483

merged 22 commits into from
Oct 11, 2019

Conversation

ben12
Copy link
Contributor

@ben12 ben12 commented May 28, 2019 •
edited
Loading

  • Fix the method getNodeState when verticalLevel is used.
  • Fix the unit tests which must be executed asynchronously.
  • Modification of the unit tests for the verticalLevel case.
  • Travis-CI environment : Upgrade to Node.js version 8 (required by gulp)

@ben12
Copy link
Contributor Author

ben12 commented Jul 24, 2019

Something is wrong ?

ben12 added 2 commits August 21, 2019 20:03
@ben12
Merge branch 'master' into bugfix/479-getNodeState-vertical-nodes
5dcdc29 
# Conflicts:
#	dist/js/jquery.orgchart.min.js
#	dist/js/jquery.orgchart.min.js.map
@ben12
Upgrade Node.js to version 8 (needed for gulp 4)
bb01470
@ben12 ben12 mentioned this pull request Sep 10, 2019
Closed
@ben12
Copy link
Contributor Author

ben12 commented Oct 3, 2019

@dabeng are you there ?

ben12 and others added 16 commits October 6, 2019 17:07
@ben12
Merge branch 'master' into bugfix/479-getNodeState-vertical-nodes
cf490f7
@dabeng
feat: update .gitignore
8d73493
@dabeng
feat: update html2canvas
73ce225
@dabeng
feat: update package.json
73043c2
@dabeng
revert package.json to avoid gulp-util error
d153353
@dabeng
feat: update .gitignore
a561f85
udpate demo folder
95c30ca
@dabeng
update ui tests
60c3f3d
@sachinsahoo11 @dabeng
Fixing drag and drop on IE and Edge
4826ea1
@sachinsahoo11 @dabeng
Fixing spacing
615ad9d
@dabeng
merge branch 'html2canvas-fix' of https://github.com/ademonte/OrgChart …
270e05f 
…into ademonte-h2c
@dabeng
Merge pull request dabeng#489 from ademonte/html2canvas-fix
9c55ee1 
Fix partial rendering on PDF and PNG export
@ben12
refs dabeng#479 - getNodeState fix for vertical nodes
76ca828
@ben12
Fix getNodeState unit tests
3877eb6
@ben12
Upgrade Node.js to version 7, required by gulp-testcafe
951742c
Merge branch 'bugfix/479-getNodeState-vertical-nodes' of https://gith…
95d147b 
…ub.com/ben12/OrgChart into ben12-pr
@dabeng dabeng merged commit b46b5c7 into dabeng:master Oct 11, 2019
@dabeng
Copy link
Owner

dabeng commented Oct 11, 2019

Thanks a lot for your awesome PR @ben12 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben12 @dabeng @sachinsahoo11