Boolean parameter value changed from false to true

[SteveWilkes]

Hey there!

First of all, great project - I have an OO mapper and have encountered a few issues, but I've had some awesome results, so thanks!

First issue: I had a simple compiled func which turned a boolean false argument passed into it to true. I can't honestly say I have a great understanding of IL, but I fixed it by changing this line in TryEmitParameter:

var asAddress = (parent == ExpressionType.Call || parent == ExpressionType.MemberAccess) && paramExpr.Type.IsValueType() && !paramExpr.IsByRef;

...to:

var asAddress = 
    (parent == ExpressionType.Call || parent == ExpressionType.MemberAccess) && 
     paramExpr.Type.IsValueType() && 
    !paramExpr.Type.IsPrimitive() && // <- don't bother for bool, int, etc
    !paramExpr.IsByRef;

I offer this more as a suggestion - like I say I'm not that familiar with IL.

Cheers,

Steve

[dadhi]

Mmm, you mean this compiles fine, but has a different IL than from System Compile?

[jogibear9988]

Can you post the Expression, so we could see if fix is correct? And also we could create a Test!

[SteveWilkes]

Sorry for the lack of detail - the Func I compiled calls a generic method on an object, passing a boolean parameter. so it's like:

var objParam = Expression.Parameter(typeof(MyObject), "myObj");
var boolParam = Expression.Parameter(typeof(bool), "isSomething");
var myMethod = methodInfo.MakeGenericMethod(type1, type2);
var call = Expression.Call(objParam, myMethod, boolParam);

var lambda = Expression.Lambda<Func<MyObject, bool>>(
    call,
    objParam,
    boolParam);

var func = lambda.CompileFast();

// Calling this invokes 'myMethod', but the value of the parameter
// is passed as true, not false:
func.Invoke(false);

I'm happy to put together a proper repro when I've got the time, I just wanted to raise this sooner rather than later :)

[jogibear9988]

I tried to reproduce like this: https://github.com/dadhi/FastExpressionCompiler/pull/145/files#diff-824573faab7536b6cb38b03fc0cbb6dc but this worked (in my branch, wich already contains some fixes)

[SteveWilkes]

The only difference I can see in the test you've written and the code where I saw the issue (which is here in the WithTypes method, around line 370) is that the called method's generic type parameters weren't in its parameter list, and the parameter was a bool. So:

bool MyMethod<T>(bool i)
{
    return object.Equals(i, false);
}

...could be your fixes sorted it out, though! :)

[SteveWilkes]

Repro repository here, using the latest code copied in from the master branch. Argument is passed as false, arrives in the invoked method as true.

[jogibear9988]

in my branch the code from your report works.

I wait refactoring from @dadhi, then I will overhaul my changes, and then I think dadhi will merge

[jogibear9988]

close?

[SteveWilkes]

Close! Thanks :)