Int and Decimal to Double conversion issues

[SteveWilkes]

Hello!

I'm seeing unexpected results with calls like these:

doubleProperty = (double)intValueHolder.Value;
doubleProperty = (double)decimalValueHolder.Value;
nullableDoubleProperty = (double?)decimalValueHolder.Value;

I'll add a PR with failing tests once I have this issue number.

Cheers,

Steve

[jogibear9988]

This one it's hard again, and will introduce more code for nullables...

Problem is conv decimal? => double
it's not included yet.

But I think we have to redo complete TryEmitConvert with nullable support in mind (For example implizit or explicit conversation with type or nullable type,...)

[dadhi]

Hi @SteveWilkes
I have fixed these case, could you check v2.0.0-preview-02 ?

[SteveWilkes]

Will do, thanks very much! :)

[SteveWilkes]

These cases look good - thanks!

In numeric comparisons and conversions, I'm getting unexpected values with:

• Nullable int -> double
• Nullable decimal -> double
• Int -> enum

I'm getting 'Common Language Runtime detected an invalid program' with:

• Float -> decimal
• Float -> nullable decimal
• Double -> decimal

I'm getting null reference exceptions being thrown in object.Equals() calls comparing (raised as issue #174):

• Decimal with a constant decimal
• Nullable decimal with a constant decimal

...and I'm getting 'Attempted to read or write protected memory. This is often an indication that other memory is corrupt.' in one case where I'm passing the result of an object.Equals(decimalProperty, decimalConstant) as a method call argument (this turned out to be my mistake).

I'll write failing tests for these cases - should I raise a new issue(s)?

Just to mention - the tests I'm performing are all coming from my FastExpressionCompiler branch - I've got 1500+ tests in there - would you prefer me to raise one issue at a time?

[dadhi]

No need, attach them here. The more tests, the more structured convert implementation will be. Thanks for writing.

[SteveWilkes]

Will do. Thanks! :)

[SteveWilkes]

Just an update - my unexpected value issues look to have all been due to a mistake I made moving the FEC source into my branch, so I think they're all solved!

[dadhi]

You mean everything is working except NRE?

[SteveWilkes]

No, I've still got the 'Common Language Runtime detected an invalid program' errors (tests now added in PR #178), one 'Attempted to read or write protected memory' (turned out to be my mistake), and one issue with a comparison / assignment of a nullable long and nullable int. I'll at least add the last one of those under this issue (test now added in PR #176).

[SteveWilkes]

Just to note - the 'Attempted to read or write protected memory' was another copy error on my part, so I've now raised all the issues I've mentioned here. Cheers!