Expression not compileable

[jogibear9988]

Todo's to fix:

• AddAssign needs to be supported
• "null" not needs to be of compared type for Codegen in (TryEmitComparison line 2845)

I've the following Expression (Debug view)

.Block(
	System.Int32 $offset,
	System.Int32 $length,
	System.Byte[] $data) {
	$offset = 0;
	$length = 0;
	$length += .If (((Machine.JTP.Jobs.System.SystemEchoJob)$job).Message == null) {
		0
	} .Else {
		(((Machine.JTP.Jobs.System.SystemEchoJob)$job).Message).Length
	};
	$length += 1;
	$data = .New System.Byte[]($length);
	.Call Machine.Core.Foundation.Base.ValueSerializer.SerializeToArray(
		((Machine.JTP.Jobs.System.SystemEchoJob)$job).Message,
		128,
		$data,
		$offset,
		.Constant<Machine.Core.Foundation.Base.ByteOrder>(Network));
	$offset = $offset + .If (((Machine.JTP.Jobs.System.SystemEchoJob)$job).Message == null) {
		0
	} .Else {
		(((Machine.JTP.Jobs.System.SystemEchoJob)$job).Message).Length
	} + 1;
	$data
}

wich could not be compiled.

Do I need to create trac down whats not yet supported? Or could you see it from the output?

[jogibear9988]

Found out...

It's about "AddAssign" is not yet supported in Line 1292

        public static bool TryEmit(object exprObj, ExpressionType exprNodeType, Type exprType,
            object[] paramExprs, ILGenerator il, ref ClosureInfo closure, ExpressionType parent)

[dadhi]

Hi,

The actual expression would be better, or you may include FEC.cs directly into your project, and debug its TryEmit method. It contains a big switch. Just set a breakpoint on its default case and see what is not supported ExpressionType.

[jogibear9988]

And also, if I try to support AddAssign as Assign only (only for testing) it will also not work, cause TryEmitComparison checks for Type equality in Line 2844 but type of "null" is object.

Can be reproduced:

    [Test]
    public void ConvertTest()
    {
        var pParam = Expression.Parameter(typeof(string), "p");

        var condition = Expression.Condition(Expression.NotEqual(pParam, Expression.Constant(null)),
            Expression.Convert(pParam, typeof(int), typeof(int).GetMethod("Parse", new[] {typeof(string)})),
            Expression.Constant(0));
        var lambda = Expression.Lambda<Func<string, int>>(condition, pParam);
        var convert1 = FastExpressionCompiler.ExpressionCompiler.CompileFast(lambda, true);
        Assert.NotNull(convert1);
    }

[dadhi]

Then closing this duplicate.

[jogibear9988]

@dadhi not really a duplicate, I also mentioned support of comparison for "null" with other type. It's not covered by the other issue

[jogibear9988]

Should I create a new issue for this?

[jogibear9988]

I created a new issue...