Require currentSecret property when updating client secret #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambie
reviewed
Aug 15, 2018
dadi/lib/controller/clients.js
Outdated
| case 'INVALID_SECRET': | ||
| return help.sendBackJSON(400, res, next)(null, { | ||
| success: false, | ||
| errors: ['The current secret supplied is not valid'] |
There was a problem hiding this comment.
Maybe change to "The supplied current secret is not valid"
jimlambie
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that non-admin clients can only update their own secret if they supply the current secret in the payload of the
PUTrequest as acurrentSecretproperty.Failing to supply a valid secret will abort the update operation and throw a 400 error.
Closes #474.