Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Update dependencies for our eslint-config #21364

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[ui] Update dependencies for our eslint-config #21364

merged 1 commit into from
Apr 24, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Apr 23, 2024 •
edited

Summary & Motivation

Update some dependencies in our eslint-config. This is prompted by the TS parser complaining about the new version.

Once this is merged, I'll publish eslint-config v1.0.15 to npm, then use it in internal.

How I Tested These Changes

TS, lint. Verify that the TS version warning is gone, and everything lints nicely.

@hellendag Graphite App
Copy link
Member Author

hellendag commented Apr 23, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag marked this pull request as ready for review April 23, 2024 15:41
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Apr 23, 2024
@github-actions GitHub Actions
Copy link

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-j61pblaf3-elementl.vercel.app
https://dish-eslint-deps.dagster-university.dagster-docs.io

Built with commit 78268d8.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-b2lq1ks25-elementl.vercel.app
https://dish-eslint-deps.components-storybook.dagster-docs.io

Built with commit 28caab6.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-7c9zvtxkv-elementl.vercel.app
https://dish-eslint-deps.core-storybook.dagster-docs.io

Built with commit 28caab6.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-92rds7ta7-elementl.vercel.app
https://dish-eslint-deps.dagster.dagster-docs.io

Direct link to changed pages:

This was referenced Apr 23, 2024
Merged
Merged
@hellendag Graphite App
Copy link
Member Author

hellendag commented Apr 24, 2024 •
edited

Merge activity

@hellendag hellendag merged commit 7e0f50d into master Apr 24, 2024
4 checks passed
@hellendag hellendag deleted the dish/eslint-deps branch April 24, 2024 14:47
nikomancy pushed a commit to nikomancy/dagster that referenced this pull request May 1, 2024
@hellendag @nikomancy
[ui] Update dependencies for our eslint-config (dagster-io#21364)
86b2b9c 
## Summary & Motivation

Update some dependencies in our eslint-config. This is prompted by the TS parser complaining about the new version.

Once this is merged, I'll publish eslint-config v1.0.15 to npm, then use it in internal.

## How I Tested These Changes

TS, lint. Verify that the TS version warning is gone, and everything lints nicely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengotow bengotow bengotow approved these changes

@salazarm salazarm Awaiting requested review from salazarm

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellendag @bengotow