[ui] Show alert for users in experimental nav flag #21371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fa2eb66. |
bengotow
approved these changes
Apr 24, 2024
Merge activity
|
hellendag
force-pushed
the
dish/overview-tabs-flagged
branch
from
b0d0333
to
4bd5409
Compare
graphite-app
bot
added
the
area: dagster-university
hellendag
force-pushed
the
dish/nav-flag-banner
branch
from
d573040
to
fa2eb66
Compare
nikomancy
pushed a commit
to nikomancy/dagster
that referenced
this pull request
May 1, 2024
## Summary & Motivation Show a dismissable alert banner on the top of the app for users who are in the new navigation flag, with a link to the relevant GH discussion. <img width="1255" alt="Screenshot 2024-04-23 at 12 08 29" src="https://github.com/dagster-io/dagster/assets/2823852/5487c798-81bc-473d-b17c-002c7716841f"> <img width="505" alt="Screenshot 2024-04-23 at 12 15 18" src="https://github.com/dagster-io/dagster/assets/2823852/89d0ea0d-4247-4552-b900-e40ddf435755"> ## How I Tested These Changes View app, verify that the banner appears. Open user settings, verify that the link appears on the dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Show a dismissable alert banner on the top of the app for users who are in the new navigation flag, with a link to the relevant GH discussion.
How I Tested These Changes
View app, verify that the banner appears. Open user settings, verify that the link appears on the dialog.