add NamespacedTagSet api #22036
Merged
add NamespacedTagSet api #22036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
This was referenced May 22, 2024
benpankow
force-pushed
the
benpankow/tag-set
branch
from
e92fd80
to
5a2e9f7
Compare
sryza
reviewed
May 22, 2024
| @@ -107,6 +107,7 @@ Pipfile.lock | |||
| .mypy_cache/ | |||
|
|
|||
| tags | |||
| !python_modules/dagster/dagster/_core/definitions/tags | |||
There was a problem hiding this comment.
We gitignore all folders named tags right now, I want to not gitignore this module
python_modules/dagster/dagster/_core/definitions/tags/tag_set.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/tags/tag_set.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/tags/tag_set.py
Outdated
Show resolved
Hide resolved
| Args: | ||
| tags (Mapping[str, str]): A dictionary of tags. | ||
| """ | ||
| kwargs = {} |
There was a problem hiding this comment.
Have you thought about whether there are ways to avoid code duplication between this and the same method in NamespacedMetadataSet?
There was a problem hiding this comment.
Updated to use NamespacedKVSet parent class
benpankow
force-pushed
the
benpankow/tag-set
branch
from
5a2e9f7
to
f076dd7
Compare
|
Ended up w/ a shared superclass, that cleans up both impls quite a bit I think |
benpankow
force-pushed
the
benpankow/tag-set
branch
from
7fe3de9
to
f551cf9
Compare
benpankow
force-pushed
the
benpankow/tag-set
branch
from
b69ffc9
to
29f89f5
Compare
sryza
approved these changes
May 24, 2024
| def extract( | ||
| cls: Type[T_NamespacedMetadataSet], metadata: Mapping[str, Any] | ||
| ) -> T_NamespacedMetadataSet: | ||
| def extract(cls: Type[T_NamespacedKVSet], metadata: Mapping[str, Any]) -> T_NamespacedKVSet: | ||
| """Extracts entries from the provided metadata dictionary into an instance of this class. |
There was a problem hiding this comment.
Suggested change
| """Extracts entries from the provided metadata dictionary into an instance of this class. | |
| """Extracts entries from the provided dictionary into an instance of this class. |
There was a problem hiding this comment.
Other sites in this docstring need to be updated.
python_modules/dagster/dagster/_core/definitions/tags/tag_set.py
Outdated
Show resolved
Hide resolved
benpankow
force-pushed
the
benpankow/tag-set
branch
2 times, most recently
from
bbd9c55
to
ff6489c
Compare
Merge activity
|
benpankow
force-pushed
the
benpankow/tag-set
branch
from
ff6489c
to
f101e67
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary Largely clones `NamespacedMetadataSet` into a new `NamespacedTagSet` ABC which can be used to define a set of tags which will be logically set together in code, and which have a namespace prefix. A bit simpler, in that all values must be strings. ## Test Plan New little unit test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Largely clones
NamespacedMetadataSetinto a newNamespacedTagSetABC which can be used to define a set of tags which will be logically set together in code, and which have a namespace prefix.A bit simpler, in that all values must be strings.
Test Plan
New little unit test suite.