-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-dbt] attach dagster/storage_kind
tag to dbt assets
#22044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on Graphite |
benpankow
changed the title
[dagster-dbt] attach dagster/storage_kind tag to dbt assets
[dagster-dbt] attach May 22, 2024
dagster/storage_kind
tag to dbt assets
benpankow
force-pushed
the
benpankow/storage-kind
branch
from
May 22, 2024 23:44
c64b984
to
a7a7df5
Compare
benpankow
force-pushed
the
benpankow/dbt-attach-storage-kind
branch
from
May 22, 2024 23:44
7a7e2c9
to
aaf8dad
Compare
benpankow
force-pushed
the
benpankow/storage-kind
branch
from
May 23, 2024 03:46
a7a7df5
to
3526bd4
Compare
benpankow
force-pushed
the
benpankow/dbt-attach-storage-kind
branch
from
May 23, 2024 03:46
aaf8dad
to
e803aba
Compare
rexledesma
approved these changes
May 23, 2024
benpankow
force-pushed
the
benpankow/storage-kind
branch
from
May 23, 2024 21:03
3526bd4
to
869c7d6
Compare
benpankow
force-pushed
the
benpankow/dbt-attach-storage-kind
branch
from
May 23, 2024 21:03
e803aba
to
a79dd70
Compare
benpankow
force-pushed
the
benpankow/storage-kind
branch
from
May 24, 2024 17:51
869c7d6
to
48743b8
Compare
benpankow
force-pushed
the
benpankow/dbt-attach-storage-kind
branch
from
May 24, 2024 17:51
a79dd70
to
2cda9d4
Compare
benpankow
force-pushed
the
benpankow/storage-kind
branch
2 times, most recently
from
May 24, 2024 20:09
a0e5621
to
e48701c
Compare
benpankow
force-pushed
the
benpankow/dbt-attach-storage-kind
branch
from
May 24, 2024 20:34
2cda9d4
to
275bef5
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…r-io#22044) ## Summary Grabs the dbt adapter_type from the manifest and uses it to set the `storage_kind` tag on dbt-output assets, by default. Users can still override this behavior in the translator if they so desire. ## Test Plan Unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grabs the dbt adapter_type from the manifest and uses it to set the
storage_kind
tag on dbt-output assets, by default.Users can still override this behavior in the translator if they so desire.
Test Plan
Unit tests.