Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-dbt] attach dagster/storage_kind tag to dbt assets #22044

Merged
merged 4 commits into from
May 24, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented May 22, 2024

Summary

Grabs the dbt adapter_type from the manifest and uses it to set the storage_kind tag on dbt-output assets, by default.

Users can still override this behavior in the translator if they so desire.

Test Plan

Unit tests.

@benpankow
Copy link
Member Author

benpankow commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@benpankow benpankow changed the title [dagster-dbt] attach dagster/storage_kind tag to dbt assets [dagster-dbt] attach dagster/storage_kind tag to dbt assets May 22, 2024
@benpankow benpankow force-pushed the benpankow/dbt-attach-storage-kind branch from 7a7e2c9 to aaf8dad Compare May 22, 2024 23:44
@benpankow benpankow force-pushed the benpankow/dbt-attach-storage-kind branch from aaf8dad to e803aba Compare May 23, 2024 03:46
@benpankow benpankow force-pushed the benpankow/dbt-attach-storage-kind branch from e803aba to a79dd70 Compare May 23, 2024 21:03
@benpankow benpankow force-pushed the benpankow/dbt-attach-storage-kind branch from a79dd70 to 2cda9d4 Compare May 24, 2024 17:51
@benpankow benpankow force-pushed the benpankow/storage-kind branch 2 times, most recently from a0e5621 to e48701c Compare May 24, 2024 20:09
Base automatically changed from benpankow/storage-kind to master May 24, 2024 20:12
@benpankow benpankow force-pushed the benpankow/dbt-attach-storage-kind branch from 2cda9d4 to 275bef5 Compare May 24, 2024 20:34
@benpankow benpankow merged commit 372322e into master May 24, 2024
1 check passed
@benpankow benpankow deleted the benpankow/dbt-attach-storage-kind branch May 24, 2024 21:57
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
…r-io#22044)

## Summary

Grabs the dbt adapter_type from the manifest and uses it to set the
`storage_kind` tag on dbt-output assets, by default.

Users can still override this behavior in the translator if they so
desire.

## Test Plan

Unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants