[ui] introduce pill for `storage_kind` tag across UI #22031

benpankow · 2024-05-22T17:22:13Z

Summary

Implements a very basic visual tag for storage_kind on assets. Right now, this special rendering only displays on the catalog page, asset list, and asset graph. A stacked PR handles adding the filtering.

Uses the same iconset as compute kind.

Test Plan

Tested locally.

benpankow · 2024-05-22T17:22:31Z

[ui] add storage kind asset search result #22097
[ui] add filters for storage kind #22041
[ui] introduce pill for storage_kind tag across UI #22031 👈
Introduce StorageKindTagSet #22029 : 2 other dependent PRs (#22037 , #22044 )
add NamespacedTagSet api #22036
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite

salazarm

sure

braunjj · 2024-05-22T18:09:40Z

super excited about this, but I think we should make sure the storage kind tags have parity with compute kind. IMO this means that I can:

See both tags on assets in the graph
See both tags on the asset detail page (already shown here)
See both tags on the assets in the list view
Filter the graph and list view by storage kind
Search by Storage Kind

LMK if you need some UI mocks for this. but I think in most cases we can just show the two tags side by side and provide a tooltip to help users discern Compute Kind vs Storage kind. I think the hover state is important because some assets might have Snowflake as both compute and storage kinds.

braunjj · 2024-05-22T18:10:28Z

I think we should stack these instead of side-by-side

benpankow · 2024-05-22T21:11:26Z

Updated to cover the major places where we display compute kind & added tooltips. Stacked a PR to add filtering.

re-request

github-actions · 2024-05-22T22:35:13Z

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-3rvpp5a58-elementl.vercel.app
https://benpankow-storage-kind-frontend-basic.core-storybook.dagster-docs.io

Built with commit 88deca2.
This pull request is being automatically deployed with vercel-action

salazarm · 2024-05-23T19:18:21Z

js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetNode.tsx

@@ -63,7 +68,18 @@ export const AssetNode = React.memo(({definition, selected}: Props) => {
            <AssetNodeChecksRow definition={definition} liveData={liveData} />
          )}
        </AssetNodeBox>
-        <AssetComputeKindTag definition={definition} style={{right: -2, paddingTop: 7}} />
+        <Box style={{right: -2}} flex={{direction: 'row-reverse', gap: 8}}>


the negative thing is weird? Does it even do anything? I would assume it doesn't since this element isnt positioned absolutely

yeah good call idt it does anything

salazarm · 2024-05-23T19:19:16Z

js_modules/dagster-ui/packages/ui-core/src/graph/KindTags.tsx

+              window.requestAnimationFrame(() =>
+                document.dispatchEvent(new Event('show-kind-info')),


this seems like a race condition waiting to happen but its an existing issue

I don't think this is in use anyway, will remove for storage kind.

sryza · 2024-05-23T20:24:53Z

When you say "catalog page", do you mean the asset details page or the catalog overview page that includes the search bar? I don't see a screenshot for the latter, and I think we should make sure to include a section on that page. Or is that in a different repo?

benpankow · 2024-05-24T21:14:04Z

When you say "catalog page", do you mean the asset details page or the catalog overview page that includes the search bar? I don't see a screenshot for the latter, and I think we should make sure to include a section on that page. Or is that in a different repo?

That's in the internal repo, will put up a PR for it - https://github.com/dagster-io/internal/pull/9902

benpankow · 2024-05-28T23:19:17Z

Merge activity

May 28, 4:19 PM PDT: @benpankow started a stack merge that includes this pull request via Graphite.
May 28, 4:20 PM PDT: Graphite rebased this pull request as part of a merge.
May 28, 4:22 PM PDT: @benpankow merged this pull request with Graphite.

## Summary Implements a very basic visual tag for `storage_kind` on assets. Right now, this special rendering only displays on the catalog page, asset list, and asset graph. A stacked PR handles adding the filtering. Uses the same iconset as compute kind. <img width="304" alt="Screenshot 2024-05-22 at 2 09 55 PM" src="https://github.com/dagster-io/dagster/assets/10215173/7988910f-642d-4f00-9753-3b0a156079a3"> <img width="391" alt="Screenshot 2024-05-22 at 1 33 08 PM" src="https://github.com/dagster-io/dagster/assets/10215173/0845ce88-e198-4dfb-a347-9cd7a949ea08"> <img width="1449" alt="Screenshot 2024-05-22 at 1 33 04 PM" src="https://github.com/dagster-io/dagster/assets/10215173/1e255c51-a5f1-4365-9b96-16121247a648"> <img width="258" alt="Screenshot 2024-05-22 at 2 09 43 PM" src="https://github.com/dagster-io/dagster/assets/10215173/8918e281-2bc0-48fb-ae03-748ef7a92fce"> ## Test Plan Tested locally.

benpankow changed the title ~~Introduce storage kind tag, helpers to @asset, @multi_asset~~ [ui] basic catalog view for storage_kind tag May 22, 2024

benpankow changed the base branch from master to benpankow/storage-kind May 22, 2024 17:22

benpankow mentioned this pull request May 22, 2024

Introduce StorageKindTagSet #22029

Merged

benpankow requested review from bengotow, sryza, salazarm and hellendag and removed request for bengotow May 22, 2024 17:25

sryza requested a review from braunjj May 22, 2024 17:27

salazarm previously approved these changes May 22, 2024

View reviewed changes

benpankow force-pushed the benpankow/storage-kind branch from 8a11115 to 6f93b35 Compare May 22, 2024 18:58

This was referenced May 22, 2024

add NamespacedTagSet api #22036

Merged

Introduce storage kind tag, helpers to @asset, @multi_asset #22037

Closed

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 3e66e26 to 9b62740 Compare May 22, 2024 19:02

benpankow force-pushed the benpankow/storage-kind branch from 6f93b35 to cf9c1cc Compare May 22, 2024 19:13

benpankow requested a review from salazarm May 22, 2024 21:06

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 9b62740 to 2853f83 Compare May 22, 2024 21:11

benpankow mentioned this pull request May 22, 2024

[ui] add filters for storage kind #22041

Merged

benpankow changed the title ~~[ui] basic catalog view for storage_kind tag~~ [ui] basic catalog view for storage_kind tag May 22, 2024

benpankow force-pushed the benpankow/storage-kind branch from cf9c1cc to c75613b Compare May 22, 2024 22:31

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 2853f83 to 24e7ff7 Compare May 22, 2024 22:31

benpankow force-pushed the benpankow/storage-kind branch from c75613b to c64b984 Compare May 22, 2024 22:32

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 24e7ff7 to 4241620 Compare May 22, 2024 22:32

benpankow mentioned this pull request May 22, 2024

[dagster-dbt] attach dagster/storage_kind tag to dbt assets #22044

Merged

benpankow force-pushed the benpankow/storage-kind branch from c64b984 to a7a7df5 Compare May 22, 2024 23:44

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 4241620 to b69358a Compare May 22, 2024 23:44

benpankow force-pushed the benpankow/storage-kind branch from a7a7df5 to 3526bd4 Compare May 23, 2024 03:46

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from b69358a to 5a459bd Compare May 23, 2024 03:47

salazarm reviewed May 23, 2024

View reviewed changes

salazarm approved these changes May 23, 2024

View reviewed changes

salazarm reviewed May 23, 2024

View reviewed changes

benpankow force-pushed the benpankow/storage-kind branch from 3526bd4 to 869c7d6 Compare May 23, 2024 21:03

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 5a459bd to 486a2b3 Compare May 23, 2024 21:03

benpankow force-pushed the benpankow/storage-kind branch from 869c7d6 to 48743b8 Compare May 24, 2024 17:51

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 486a2b3 to 06b0c88 Compare May 24, 2024 17:52

benpankow force-pushed the benpankow/storage-kind branch 2 times, most recently from a0e5621 to e48701c Compare May 24, 2024 20:09

Base automatically changed from benpankow/storage-kind to master May 24, 2024 20:12

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 06b0c88 to df7fad4 Compare May 24, 2024 20:35

benpankow mentioned this pull request May 24, 2024

[ui] add storage kind asset search result #22097

Merged

benpankow changed the title ~~[ui] basic catalog view for storage_kind tag~~ [ui] introduce pill for storage_kind tag across UI May 24, 2024

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 775f524 to b1d13cb Compare May 28, 2024 21:35

benpankow added 4 commits May 28, 2024 23:19

[ui] basic catalog view for storage_kind tag

4981bc5

update other views

c1bb1dd

tooltip

c7c58de

respond to review comments

88deca2

benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from b1d13cb to 88deca2 Compare May 28, 2024 23:19

benpankow merged commit 5ad3b82 into master May 28, 2024
1 of 2 checks passed

benpankow deleted the benpankow/storage-kind-frontend-basic branch May 28, 2024 23:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui] introduce pill for `storage_kind` tag across UI #22031

[ui] introduce pill for `storage_kind` tag across UI #22031

benpankow commented May 22, 2024 •

edited

Loading

benpankow commented May 22, 2024 •

edited

Loading

salazarm left a comment

braunjj commented May 22, 2024

braunjj commented May 22, 2024

benpankow commented May 22, 2024

github-actions bot commented May 22, 2024 •

edited

Loading

salazarm May 23, 2024

benpankow May 24, 2024

salazarm May 23, 2024

benpankow May 24, 2024

sryza commented May 23, 2024

benpankow commented May 24, 2024 •

edited

Loading

benpankow commented May 28, 2024 •

edited

Loading

		window.requestAnimationFrame(() =>
		document.dispatchEvent(new Event('show-kind-info')),

[ui] introduce pill for storage_kind tag across UI #22031

[ui] introduce pill for storage_kind tag across UI #22031

Conversation

benpankow commented May 22, 2024 • edited Loading

Summary

Test Plan

benpankow commented May 22, 2024 • edited Loading

salazarm left a comment

Choose a reason for hiding this comment

braunjj commented May 22, 2024

braunjj commented May 22, 2024

benpankow commented May 22, 2024

github-actions bot commented May 22, 2024 • edited Loading

salazarm May 23, 2024

Choose a reason for hiding this comment

benpankow May 24, 2024

Choose a reason for hiding this comment

salazarm May 23, 2024

Choose a reason for hiding this comment

benpankow May 24, 2024

Choose a reason for hiding this comment

sryza commented May 23, 2024

benpankow commented May 24, 2024 • edited Loading

benpankow commented May 28, 2024 • edited Loading

Merge activity

[ui] introduce pill for `storage_kind` tag across UI #22031

[ui] introduce pill for `storage_kind` tag across UI #22031

benpankow commented May 22, 2024 •

edited

Loading

benpankow commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

benpankow commented May 24, 2024 •

edited

Loading

benpankow commented May 28, 2024 •

edited

Loading