Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] add filters for storage kind #22041

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented May 22, 2024

Summary

Add frontend filters for storage kind to the asset list and asset graph pages.

Screenshot 2024-05-22 at 2 14 30 PM

Test Plan

Tested locally

@benpankow
Copy link
Member Author

benpankow commented May 22, 2024

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 2853f83 to 24e7ff7 Compare May 22, 2024 22:31
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from 2f52bb6 to fb0a3b5 Compare May 22, 2024 22:31
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 24e7ff7 to 4241620 Compare May 22, 2024 22:32
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from fb0a3b5 to e5b383b Compare May 22, 2024 22:33
Copy link

github-actions bot commented May 22, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-kz2fehr9f-elementl.vercel.app
https://benpankow-storage-kind-filter.core-storybook.dagster-docs.io

Built with commit b239dd8.
This pull request is being automatically deployed with vercel-action

@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 4241620 to b69358a Compare May 22, 2024 23:44
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from e5b383b to b373fe7 Compare May 22, 2024 23:44
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from b69358a to 5a459bd Compare May 23, 2024 03:47
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from b373fe7 to 48b55af Compare May 23, 2024 03:47
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 5a459bd to 486a2b3 Compare May 23, 2024 21:03
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from 280906b to be6151b Compare May 23, 2024 21:03
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 486a2b3 to 06b0c88 Compare May 24, 2024 17:52
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from be6151b to 99654ce Compare May 24, 2024 17:52
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 06b0c88 to df7fad4 Compare May 24, 2024 20:35
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch 2 times, most recently from 70a9fbd to db29512 Compare May 24, 2024 21:14
@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from 775f524 to b1d13cb Compare May 28, 2024 21:35
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from db29512 to 340b26a Compare May 28, 2024 21:35
@benpankow
Copy link
Member Author

benpankow commented May 28, 2024

Merge activity

  • May 28, 4:19 PM PDT: @benpankow started a stack merge that includes this pull request via Graphite.
  • May 28, 4:23 PM PDT: Graphite rebased this pull request as part of a merge.
  • May 28, 4:24 PM PDT: @benpankow merged this pull request with Graphite.

@benpankow benpankow force-pushed the benpankow/storage-kind-frontend-basic branch from b1d13cb to 88deca2 Compare May 28, 2024 23:19
Base automatically changed from benpankow/storage-kind-frontend-basic to master May 28, 2024 23:22
@benpankow benpankow force-pushed the benpankow/storage-kind-filter branch from 340b26a to b239dd8 Compare May 28, 2024 23:22
@benpankow benpankow merged commit d47c5b3 into master May 28, 2024
1 of 2 checks passed
@benpankow benpankow deleted the benpankow/storage-kind-filter branch May 28, 2024 23:24
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary

Add frontend filters for storage kind to the asset list and asset graph pages.

<img width="562" alt="Screenshot 2024-05-22 at 2 14 30 PM" src="https://github.com/dagster-io/dagster/assets/10215173/4a201721-3517-4021-9243-67482722c6d9">

## Test Plan

Tested locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants