-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce storage kind tag, helpers to @asset, @multi_asset #22037
base: master
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on Graphite |
6f93b35
to
cf9c1cc
Compare
7b6f045
to
df7c039
Compare
cf9c1cc
to
c75613b
Compare
df7c039
to
e61f764
Compare
c75613b
to
c64b984
Compare
e61f764
to
e573a39
Compare
c64b984
to
a7a7df5
Compare
e573a39
to
8ee5f8e
Compare
a7a7df5
to
3526bd4
Compare
8ee5f8e
to
842c506
Compare
Definitely prefer moving forward with #22029 (which I will approve now because it is a 2-way door) for the time being and holding off on this until we understand more. Is there a doc describing this new tag type and the plans for it? I'm also curious re: @braunjj 's take on this, as he has been advocating for a storage kind or something like it for a long time. |
I'm supportive of this (and it has been requested by users a few times ASAIK. I think it's important that Storage Kind has parity with Compute Kind. For example you should be able to filter and group assets by storage kind just like you can with compute kinds. @benpankow has implemented a bunch of that filtering so I feel good about this. I think we might want to rethink how these tags appear on asset nodes and list views in the future now that assets can have Compute, Storage, and other arbitrary tags; but I don't think this is blocking any short term progress. I think our users will be very happy about this change. |
The goal of the storage kind tag is to enable users to be able to sort & filter their assets by destination and to give an immediate indication of what data backs and asset at a glance when browsing in the catalog. Right now it can be tricky to immediately distinguish which assets live in a warehouse vs in blob storage vs a database or SaaS tool unless they're named strategically - compute kind is often not enough in cases where tools like A couple user flows which get a lot easier with this metadata:
The basic UI implementation from #22031 and #22041 looks like the following: |
3526bd4
to
869c7d6
Compare
842c506
to
dbce519
Compare
869c7d6
to
48743b8
Compare
dbce519
to
c91b228
Compare
48743b8
to
a0e5621
Compare
c91b228
to
139e907
Compare
a0e5621
to
e48701c
Compare
139e907
to
7ade35a
Compare
Awesome feature! |
#14475 related issue |
7ade35a
to
aa54331
Compare
Internal discussion for cross-linking purposes https://github.com/dagster-io/internal/discussions/9937 |
Summary
Introduces a
storage_kind
param to@asset
,@multi_assets
decorator and toAssetSpec
which sets thedagster/storage_kind
tag from #22029 on the corresponding assets, similar to thekind
tag we set on ops fromcompute_kind
.This is much more committal than #22029, so ok holding off for now.
This can be displayed in the UI specially as well as automatically populated by our various integrations.
Test Plan
Unit tests.