Fixed PR #23162 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the following changes: - an idempotency fix when `profile: any` - better difference output to debug idempotency issues - documentation fixes (remove `required: false`) - Parameter handling fixes - RDP example that matches default RDP rule - Renamed parameter 'enable' to 'enabled' (kept alias) - Renamed parameter 'profile' to 'profiles' (kept alias)
ar7z1
commented
Apr 10, 2017
| @@ -114,7 +114,7 @@ function getFirewallRule ($fwsettings) { | |||
| Continue | |||
| } else { | |||
| $diff=$true; | |||
| $difference+=@("$($fwsetting.Key): $($output.$($fwsetting.Key)) vs $($fwsettings.$($fwsetting.Key))"); | |||
| $difference+=@("'$($fwsetting.Key.ToLower())': '$($output.$($fwsetting.Key).ToLower())' vs '$($fwsettings.$($fwsetting.Key))'") | |||
There was a problem hiding this comment.
Change from Action: Allow vs block to 'action': 'allow' vs 'block'.
ar7z1
commented
Apr 10, 2017
| @@ -157,6 +157,10 @@ function createFireWallRule ($fwsettings) { | |||
| $key='dir' | |||
| } elseif ($fwsetting.key -eq 'Rule Name') { | |||
| $key='name' | |||
| } elseif ($fwsetting.key -eq 'Enabled') { | |||
There was a problem hiding this comment.
Revert firewall rule building procedure. Shippable build failed because of this.
ar7z1
commented
Apr 10, 2017
| @@ -103,7 +103,7 @@ | |||
| that: | |||
| - add_different_firewall_rule_without_force.failed == true | |||
| - add_different_firewall_rule_without_force.changed == false | |||
| - add_different_firewall_rule_without_force.difference == ["block"] | |||
| - add_different_firewall_rule_without_force.difference == ["'action'{{':'}} 'allow' vs 'block'"] | |||
dagwieers
force-pushed
the
wfr_idempotency
branch
14 times, most recently
from
208e471
to
61aaf1f
Compare
dagwieers
force-pushed
the
wfr_idempotency
branch
from
7efa8b6
to
d115b02
Compare
dagwieers
force-pushed
the
wfr_idempotency
branch
from
d115b02
to
4359099
Compare
dagwieers
pushed a commit
that referenced
this pull request
Feb 12, 2020
* New module zabbix_service (#5) * new module zabbix_service * fix type * fix githubid * New Zabbix service module (ansible#11) * new zabbix service module * fix validate module failure * Fix algorithm doc and all_childs param name * Update Ansible version Co-Authored-By: sky-joker <megane@kurobuti.com> * remove dump state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I repaired firewall rule build procedure, fixed failed tests and made
$differencestring more beautiful.