[문자열 덧셈 계산기] 커스텀 구분자를 가지는 문자열을 구분자를 기준으로 분리한다 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com>
Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com>
dahyen0o
added a commit
that referenced
this pull request
Jul 8, 2023
* docs: [문자열 덧셈 계산기] 미션 요구사항, 1차 기능 목록 작성 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [문자열 덧셈 계산기] 기본 구분자를 가지는 문자열을 구분자를 기준으로 분리한다 (#1) * test: '기본 구분자만 포함했을 때 파싱 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '기본 구분자만 포함했을 때 파싱 성공' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * [문자열 덧셈 계산기] 커스텀 구분자를 가지는 문자열을 구분자를 기준으로 분리한다 (#2) * test: '커스텀 구분자만 포함할 때 파싱 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '커스텀 구분자만 포함할 때 파싱 성공' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * [문자열 덧셈 계산기] 숫자 이외의 값 또는 음수인 경우 예외를 발생시킨다 (#3) * test: '숫자가 아닌 문자를 포함할 때 파싱 실패' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '숫자가 아닌 문자를 포함할 때 파싱 실패' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * [문자열 덧셈 계산기] 각 숫자의 합을 구한다 (#4) * test: '올바른 문자열일 때 계산 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '올바른 문자열일 때 계산 성공' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * docs: [문자열 덧셈 계산기] 2차 사이드 이펙트 보완 목록 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '올바른 문자열 일 때 계산 성공' 테스트 self-validation 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [문자열 덧셈 계산기] 2차 사이드 이펙트 보완 목록 (#5) * test: '올바른 문자열 일 때 계산 성공' 테스트 케이스(null 일 때) 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: 입력값이 null 일 때 결과값을 반환하는 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '올바른 문자열 일 때 계산 성공' 테스트 케이스(입력값이 숫자 하나일 때) 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '범위 밖 숫자 입력 시 파싱 실패' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '계산 결과가 정수 범위를 벗어날 때 계산 실패' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '계산 결과가 정수 범위를 벗어날 때 계산 실패' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * docs: [문자열 덧셈 계산기] 3차 리팩토링 목록 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * docs: [문자열 덧셈 계산기] 3차 리팩토링 목록 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [문자열 덧셈 계산기] 3차 리팩토링 목록 (#6) * refactor: 파싱 클래스 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 계산 클래스 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 입력 처리 클래스 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: 리팩토링 후 실패 테스트 수정, parameterized test 를 사용해 테스트 코드 수정 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: dahyen0o <seeunchoi99@gmail.com> * docs: [자동차 경주] 미션 요구사항, 1차 기능 목록 작성 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 각 시행마다 0~9 사이의 랜덤값을 구하고, 전진할 자동차를 결정한다 (#8) * test: '랜덤값 생성 요청했을 때 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '랜덤값 생성 요청했을 때 성공' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '전진 혹은 멈추는 범위의 수가 들어왔을 때 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '전진 혹은 멈추는 범위의 수가 들어왔을 때 성공' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 입력이 주어질 때 파싱 성공/실패 (#9) * test: '입력이 주어질 때 파싱 성공/실패' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '입력이 주어질 때 파싱 성공/실패' 코드 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 자동차 생성 및 전진 성공 (#10) * test: '자동차 생성할 때 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '자동차 생성할 때 성공' 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '자동차 전진 요청할 때 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '자동차 전진 요청할 때 성공' 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 경주 생성 및 진행 구현 (#11) * test: '경주 생성할 때 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '경주 생성할 때 성공' 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '경주 진행할 때 시행 횟수 차감 성공' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '경주 진행할 때 시행 횟수 차감 성공' 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: '경주 진행할 때 자동차 전진/정지 성공' 테스트 추가 및 기존 테스트 리팩토링 테스트를 위한 NumberGenerator 인터페이스 분리 항상 고정값을 반환하는 FixedNumberGenerator 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '경주 진행할 때 자동차 전진/정지 성공' 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 입력, 출력, 애플리케이션 실행 기능 (#12) * feat: 우승자 이름 반환 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: 입력 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: 출력 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: 애플리케이션 실행 기능 구현 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * docs: [자동차 경주] 2차 사이드 이펙트 보완 목록 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 2차 사이드 이펙트 보완 목록 (#13) * test: '잘못된 입력이 들어온 경우 예외 발생' 테스트 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * feat: '잘못된 입력이 들어온 경우 예외 발생' 기능 추가 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * docs: [자동차 경주] 3차 리팩토링 목록 작성 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [자동차 경주] 3차 리팩토링 (#14) * refactor: 패키지 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 원시값과 문자열 포장 (자동차 이름, 자동차 위치) Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor : 원시값과 문자열 포장 (자동차 이름, 자동차 위치)에 따른 테스트 코드 수정, Parser의 유효성 검사 삭제 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 원시값과 문자열 포장 (시행 횟수) Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: Parser 삭제, Request -> RaceRequest 클래스 이름 수정 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: Response -> RaceResponse 클래스 이름 변경 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 일급 컬렉션 Cars 추가, 테스트 코드 수정 Race 내부에서 Car을 생성하도록 변경 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: Application 로직을 RaceController 로 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: test 계층 분리 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * [문자열 덧셈 계산기] 3차 리팩토링 (#15) * refactor: 원시값(숫자) 포장 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> * test: ParameterizedTest name 설정 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> * refactor: 에러 메세지 및 상수 값 추출 Co-authored-by: dahyen0o <seeunchoi99@gmail.com> Co-authored-by: PPakSang <sanghyun-dev@naver.com> --------- Co-authored-by: PPakSang <sanghyun-dev@naver.com> Co-authored-by: SangHyun-Park <51109514+PPakSang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.