-
Notifications
You must be signed in to change notification settings - Fork 4
Add screen sharing support #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dcb6236
wip screen sharing support
lazeratops b21f4dc
remove log lines
lazeratops c7080f6
use screen icons, styling
lazeratops 582a398
styling, ensure screen share name is in the right place
lazeratops f3a8f76
Dedup, styling
lazeratops 457cf9b
remove unneeded parameter
lazeratops 3a3beaa
Don't show screen sharing controls unless screen sharing is enabled i…
lazeratops 5c0c820
More consistent naming
lazeratops 531ab79
Fix entering and leaving zone with another participant screen sharing
lazeratops 3e1b8e1
more edge cases + comments
lazeratops 881bf48
more comments
lazeratops 91740df
Reset screen share controls between meetings
lazeratops 6f87ec2
Check if browser supports screen sharing before retrieving room config
lazeratops 4f39781
cleanup
lazeratops 5007b7c
add aria-label
lazeratops 5263166
add space
lazeratops 163a885
Update comment, run prettier (which has converted line breaks to LF a…
lazeratops 9e32a84
Fix disabling of screen share button when user exits zone (remove the…
lazeratops File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to screen sharing, just removing an unneeded directive