Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 14.04 IPython notebook does not have IPython.menu._size_header #57

Merged
merged 1 commit into from
Feb 15, 2015

Conversation

tjwei
Copy link
Contributor

@tjwei tjwei commented Feb 5, 2015

live_real did not work for me. My IPython notebook is ver 2.31 bundled in Ubuntu 14.04 (apt-get version).
I check the javascript console and find out an error caused by IPython.menu._size_header not defined. After I commented out these line, live_real seems to work fine.
So I add a check to see whether IPython.menu._size_header is defined before calling it.

@damianavila
Copy link
Owner

WAT? it is working normally only with this change? I would expect master do not work with 2.3.1, since of the layout machinery change a lot....
OK, I will take a look at this and test it and if it fully working, I am surely merging this soon... thanks!

@damianavila
Copy link
Owner

This fix just one of the issues, I will submit another PR solving the rest of them, so master will be compatible again with 2.3.x and 2.4.x versions of IPython... merging this one as is. Thanks!

damianavila added a commit that referenced this pull request Feb 15, 2015
Ubuntu 14.04 IPython notebook does not have IPython.menu._size_header
@damianavila damianavila merged commit 3f23e98 into damianavila:master Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants