-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include .m3u8 for video playback to enable streaming #1372
Conversation
Although it starts m3u8 playback for VOD, the size and aspect ration is wrong and broken. |
On Sun, Jul 16, 2023 at 06:43:45AM -0700, Fishcake wrote:
Although it starts m3u8 playback for VOD, the size and aspect ration is wrong and broken.
is there a note I could test this on?
|
Ok, I've done some additional modifications to fix aspect ratio and sizing for the HLS streams, but I have no idea what I am doing, so it could be very wrong. Here is npub that has 5 HLS streams in the notes: npub1fshcake8n69420zyzv4fezx98tuhr30zy6n09gfgkl39p3haqe4qae8ktp Here are the notes' IDs: Here is the link to the video showing how it works now: |
e49f31f
to
a0f4630
Compare
Ok, I opted for a hack to handle audio detection in HLS stream, and it works now. The downside it is always assuming that audio is present. It's not a bad assumption, but not ideal. |
Here is the latest use of the build with this PR applied: |
For more m3u8 streams, you can get them from https://videojs-http-streaming.netlify.app/ |
After some more research, to make this work properly, some part of the player need to be rewritten. It is impossible to get the video size correctly with the current method, and the best I could find that is current is the implementation in https://github.com/apivideo/api.video-swift-player/tree/main |
Closing this one since I just don’t have expertise in Swift to reimplement video player to be able to work with stream. |
This trivial change should enable HLS streaming and adaptable bit rate playback for video playback.