-
Notifications
You must be signed in to change notification settings - Fork 195
Add ore dictionary support to all recipes #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
See dan200#517 for motivation
Can one of the admins verify this patch? |
It's possible to acquire any mob head in vanilla, so it's probably best if we allow any head to be used.
@@ -1,7 +1,7 @@ | |||
{ | |||
"type": "minecraft:crafting_shapeless", | |||
"ingredients": [ | |||
{ "item": "minecraft:skull", "data": 1 }, | |||
{ "item": "minecraft:skull", "data": 32767 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wildcard metadata is deprecated by Mojang, it will no longer work in 1.13 and does not show properly in the recipe book in 1.12. Mojang replaced all uses of it with a list of ingredients. Since its reused, make that list of skulls a constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, thanks. I've used it without problem with JEI, but forgot to test the recipe book.
Out of interest, what's the recommended way of dealing with items like wool, where there's no corresponding ore-dict entry? Obviously in 1.13 we can use item tags, but it also seems a little sub-optimal to list all 16 variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all recipes that use all 16 variants of wool in 1.12 listed all 16 variants. You could also just add your own oredict entry to the vanilla items to supplement until tags are added in 1.13, as I'm sure other mods add their own wools too for the oredict
…ore-dict Add ore dictionary support to all recipes
This allows people to use alternative items, such as Quark chests or dyed glass panes, in recipes instead of the "standard" one. The former is especially useful as Quark makes it much harder to acquire a "standard" chest.