New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ore dictionary support to all recipes #517

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@SquidDev
Contributor

SquidDev commented Feb 4, 2018

This allows people to use alternative items, such as Quark chests or dyed glass panes, in recipes instead of the "standard" one. The former is especially useful as Quark makes it much harder to acquire a "standard" chest.

SquidDev added a commit to SquidDev-CC/ComputerCraft that referenced this pull request Mar 15, 2018

@thatcraniumguy

This comment has been minimized.

thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?

Allow using any kind of skull for crafting heads
It's possible to acquire any mob head in vanilla, so it's probably best
if we allow any head to be used.
@@ -1,7 +1,7 @@
{
"type": "minecraft:crafting_shapeless",
"ingredients": [
{ "item": "minecraft:skull", "data": 1 },
{ "item": "minecraft:skull", "data": 32767 },

This comment has been minimized.

@KnightMiner

KnightMiner Jun 2, 2018

The wildcard metadata is deprecated by Mojang, it will no longer work in 1.13 and does not show properly in the recipe book in 1.12. Mojang replaced all uses of it with a list of ingredients. Since its reused, make that list of skulls a constant

This comment has been minimized.

@SquidDev

SquidDev Jun 2, 2018

Contributor

Ahhh, thanks. I've used it without problem with JEI, but forgot to test the recipe book.

Out of interest, what's the recommended way of dealing with items like wool, where there's no corresponding ore-dict entry? Obviously in 1.13 we can use item tags, but it also seems a little sub-optimal to list all 16 variants.

This comment has been minimized.

@KnightMiner

KnightMiner Jun 2, 2018

Yeah, all recipes that use all 16 variants of wool in 1.12 listed all 16 variants. You could also just add your own oredict entry to the vanilla items to supplement until tags are added in 1.13, as I'm sure other mods add their own wools too for the oredict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment