Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #84

Merged
merged 10 commits into from
Apr 19, 2020
Merged

Clean up #84

merged 10 commits into from
Apr 19, 2020

Conversation

danemesis
Copy link
Owner

No description provided.

@danemesis danemesis requested review from jmelnych and Proladge April 18, 2020 11:02
@danemesis
Copy link
Owner Author

#85 has to be merged first

@danemesis danemesis marked this pull request as draft April 18, 2020 17:27
Proladge
Proladge previously approved these changes Apr 19, 2020

// This informs the Telegram servers of the new webhook
bot.setWebHook(`${ngRokUrl}/bot${Config.TELEGRAM_TOKEN}`);
bot.setWebHook(`${appUrl}/bot${Config.TELEGRAM_TOKEN}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danbilokha do you mind adding TELEGRAM_TOKEN as a parameter.
That we we will have this index independent from environment but only from parameters passed

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@danemesis danemesis marked this pull request as ready for review April 19, 2020 15:02
Copy link
Collaborator

@Proladge Proladge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danemesis danemesis merged commit ed709d8 into master Apr 19, 2020
@danemesis danemesis deleted the feature/dbilokha/cleanup branch April 19, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants