Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BitBucketServer personal projects are not taken into consideration #1121

Closed
danibaeyens opened this issue Feb 25, 2021 · 0 comments · Fixed by #1122
Closed

[BUG] BitBucketServer personal projects are not taken into consideration #1121

danibaeyens opened this issue Feb 25, 2021 · 0 comments · Fixed by #1122
Labels

Comments

@danibaeyens
Copy link
Contributor

Describe the bug
In BitbucketServer you can use project repositories, but you can also create your own personal repositories in your account. These follow a slightly different path structure:

https://bitbucker.server/projects/FOO/repos/BAR/pull-requests/1
https://bitbucker.server/projects/~user/repos/BAR/pull-requests/1

In case danger is invoked for a personal project, the resolved API path is wrong

See docs: https://docs.atlassian.com/bitbucket-server/rest/5.16.0/bitbucket-rest.html#personal-repositories

To Reproduce
Steps to reproduce the behaviour:

  1. run danger pr https://bitbucker.server/projects/FOO/repos/BAR/pull-requests/1
  2. danger will get a 404 unable to fetch a correctly resolved API call

Expected behaviour
In our case, the bitbucket server host structure has a root path, which can be also relevant to the scenario:

Your Environment

software version
danger.js 10.6.3
node 14.16.0
npm 7.5.6
Operating System macOS 10.15.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant