Fix publishing Docker image to GitHub

[markuspoerschke]

The workflow definition was copied from https://docs.github.com/en/actions/guides/publishing-docker-images#publishing-images-to-github-packages.

No changes were needed to publish the docker image to GitHub's container registry.

You can find a successfull run here: https://github.com/markuspoerschke/danger-js/runs/2240530067?check_suite_focus=true (since you can test it only once you released a new version...)

[markuspoerschke]

Fixes #923

[f-meloni]

Is this action using the org's package registry or is it deploying the package directly on the danger-js repo's package?
We moved the various docker images all under the Danger org's package registry (e.g., https://github.com/orgs/danger/packages/container/package/danger-swift), that offers a better handling of the Docker Packages (You can for example make them public and don't require authentication to use them so that you can directly import the docker package from the action using docker://), and should be the suggested one.

[f-meloni]

I think this should be

Suggested change

	registry: docker.pkg.github.com
	repository: danger/danger-js/danger-danger-js
	registry: ghcr.io/danger
	repository: danger-js

But I'm not familiar with this action

[markuspoerschke]

Is this action using the org's package registry or is it deploying the package directly on the danger-js repo's package?

It is currently using the repo's package. I will change it to the organizations namespace.

I will keep the host name as mentioned in the official documentation. ghcr.io is an alias only.

[markuspoerschke]

I just double checked. There is a difference in the hostnames: https://docs.github.com/en/packages/guides/migrating-to-github-container-registry-for-docker-images

It is recommended to use ghcr.io to use the GitHub Container Registry. So I will change this as well.

[markuspoerschke]

I checked the official documentation and there is another exmaple how to use ghcr.io. To me it looked clear to copy the initial example.

I will check

• https://docs.github.com/en/packages/guides/using-github-packages-with-github-actions#upgrading-a-workflow-that-accesses-ghcrio
• and the other danger repository.

The above changes did not work in my fork. I will test there before opening this PR again.

[markuspoerschke]

Docker Image Build Process at Danger Systems

Problem

The Danger JS is currently not publishing an up to date Docker Image. To stay compliant with the other Danger projects, the build process for Docker Images should be according to the other projects.

Objective

Danger JS should provide an up to date Docker Image. This analysis should defined

• to where the Docker Image is published

• how the build process looks like

Related Danger Projects

The following Danger projects are considered in this analysis:

• Danger JS (this project)

• Danger Swift

• Danger Ruby (the original project)

• Danger Kotlin

• Danger Python

Analysis

	Published to	Build process	Remarks
JS	docker.pkg.github.com/danger/danger-js/danger-danger-js	GitHub Action	Build Process is broken
Swift	ghcr.io/danger/danger-swift	GitHub Action
Ruby	hub.docker.com/r/dangersystems/danger-rb	Docker Hub	Only latest development build, no tags
Kotlin	ghcr.io/danger/danger-kotlin	GitHub Action
Python	?	?	I could not find any published Docker Image

Conclusion

The implementations for Swift and Kotlin are providing a working Docker Image. They are using the recommended GitHub Container Registry for Docker Images.

Danger JS should use the same mechanism to build and publish like Kotlin and Swift.

The Build script for Docker Images can be copied from Kotlin. It was most recently edited by @f-meloni who might be able to help setting up the correct secrets.

[orta]

Seems reasonable to me, doesn't look like it changes my deploy flow at all 👍🏻

[f-meloni]

Looks good to me.
@orta if you want I can add my secrets here as well, like I did on the other danger versions.

[orta]

Sure, do it 👍🏻

[shyim]

What's missing here? I can help when needed :)

[f-meloni]

Sure, do it 👍🏻

I've added the secrets, so we should be fine

[orta]

OK, then we'll see on the next release 👍🏻