Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: parameters of createComment in Executor.ts #1381

Closed
wants to merge 1 commit into from
Closed

Fix: parameters of createComment in Executor.ts #1381

wants to merge 1 commit into from

Conversation

Xiaobo2020
Copy link

Related issue: #1380

fbartho
fbartho requested changes May 19, 2023
View reviewed changes
Copy link
Member

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a breaking change to the whole platform API.

Instead how about you fix the Gitlab-only-issue by making changes inside the GitLab::createComment?

@fbartho
Copy link
Member

fbartho commented May 19, 2023

danger-js/source/platforms/GitLab.ts

Line 126 in 899a820

createComment = async (comment: string): Promise<GitLabNote> => {

@glensc glensc mentioned this pull request Jul 30, 2023
Merged
@glensc
Copy link
Contributor

glensc commented Jul 30, 2023 •
edited
Loading

@fbartho: Re-created this PR using review notes:

@glensc glensc mentioned this pull request Jul 30, 2023
Closed
@orta orta closed this in #1395 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbartho fbartho fbartho requested changes

Assignees
No one assigned
Labels
[platform] GitLab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaobo2020 @fbartho @glensc