Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local execution for lint-staging like tests #473

Merged
merged 17 commits into from
Jan 21, 2018
Merged

Conversation

orta
Copy link
Member

@orta orta commented Jan 6, 2018

Supersedes #309

screen shot 2018-01-06 at 10 37 37 pm

Adds a new command which will run Danger against local state, and with a null danger.github.

This can be used to show messages in pre-push conditions, for example on this repo, when you push:

screen shot 2018-01-06 at 10 42 28 pm

It runs the dangerfile dangerfile.lite.ts. 👍

TODO:

  • Handle just staged files for a pre-commit?
  • Pass the merge base option into the runner. Right now it will always be done against master.
  • Whatever broke in danger
  • More tests

@orta orta changed the title WIP on local execution for lint-staging like tests Local execution for lint-staging like tests Jan 7, 2018
@orta orta changed the title Local execution for lint-staging like tests WIP: Local execution for lint-staging like tests Jan 7, 2018
@adam-moss
Copy link
Contributor

Nice one, sadly I've been time poor of late so am looking forward to seeing this landed 👍

@orta
Copy link
Member Author

orta commented Jan 21, 2018

This PR was blocked for two weeks because of a this issue. ERGH.

@orta orta changed the title WIP: Local execution for lint-staging like tests Local execution for lint-staging like tests Jan 21, 2018
@orta
Copy link
Member Author

orta commented Jan 21, 2018

OK, I'm pretty sure this is now good to go.

@orta orta merged commit f7a5287 into master Jan 21, 2018
@orta orta deleted the adam-moss-local-run branch January 21, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants