New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move report logic on a separate file #111

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
1 participant
@f-meloni
Copy link
Member

f-meloni commented Nov 19, 2018

This doesn't anything much in how the code works, but gives some benefits in readability.
Even if now DangerRunner is internal, it should be fine because it can not be seen from outside the framework and the init is still private, then you can not initialise another copy of it by mistake.

f-meloni added some commits Nov 19, 2018

@f-meloni f-meloni requested a review from orta Nov 20, 2018

@f-meloni f-meloni merged commit 93b7d50 into master Nov 20, 2018

2 checks passed

Peril All green. Jolly good show.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the report_on_another_file branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment