Use /bin/sh as command line interpreter #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShellExecutor
considers$SHELL
environment variable to decide which shell should be used.Actually POSIX permits to set
$SHELL
to any kind of command line interpreter even it doesn't conform to the specification for shell command interpreter.Potentially users even can do
sudo chsh -s /usr/bin/python
and in that case,danger-swift
doesn't work properly.Therefore I changed
ShellExecutor
not to depend on the environment variable but just use POSIX standard/bin/sh
./bin/sh
is guaranteed to be there and it must be a bsh-compatible shell script language interpreter.