Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make draft optional for some repos which Draft pull requests are not available in GitHub Pulls #378

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Make draft optional for some repos which Draft pull requests are not available in GitHub Pulls #378

merged 3 commits into from
Sep 23, 2020

Conversation

417-72KI
Copy link
Member

May resolve #376.

I'm not sure about actual specs but according to this reference, Draft PR is not available on some repositories and draft property may be null on this case.

Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@f-meloni f-meloni merged commit 6cf7149 into danger:master Sep 23, 2020
@417-72KI 417-72KI deleted the github-pr-draft-if-unavailable branch September 23, 2020 09:16
@rr-james-hickman
Copy link

@f-meloni Are you planning to generate a new release with this fix? Having the same issues but your last release was from January: https://github.com/danger/swift/releases?after=3.1.0

@f-meloni
Copy link
Member

f-meloni commented Oct 9, 2020

@rr-james-hickman The last danger-swift release was 24 days ago

@rr-james-hickman
Copy link

@f-meloni Ah ok. Releases page wasn't reflecting that. However, this fix was merged in 16 days ago, so when do you expect a new release for it?
Much appreciated! 🍻

@f-meloni
Copy link
Member

f-meloni commented Oct 9, 2020

I've just released 3.6.0 with this change inside 🍻

If you are using the docker image in the GitHub Package Registry that should be ready in around 5 mins

@rr-james-hickman
Copy link

@f-meloni You rock! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to Parse JSON GitHub Enterprise
3 participants