-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SwiftLint (0.50.3) version in Dockerfile used in danger-swift-with-swiftlint
container.
#573
Conversation
…-with-swiftlint` container SwiftLint release: https://github.com/realm/SwiftLint/releases/tag/0.50.3
@f-meloni could we try to create a new version of the If something fails while building the container we can easily roll back, although I tried |
Yes, I'm currently not at home, but will be back and release beginning of next week 🙂 |
Awesome! Thank you very much! |
Thanks for merging @f-meloni! 🙏🏼 Is there any date scheduled for the next release? Is there a way I can fetch a docker container including these changes? Thank you. |
I have done the release, but the build failed because the new swiftlint requires bazel |
Oh, no! I had no idea about that, sorry it broke the release. |
No problem at all :) it can still be fixed or reverted, everything else but the container with swiftlint should be working ok |
Any idea what could be the solution here to allow using the 3.16.0 container with SwiftLint? I believe Bazel can be installed via npm ( |
I had tried with apt get before, and had some issues with the versioning.
After installing that and setting CC=clang as required, I still get
|
This PR aims to update SwiftLint to version
0.50.3
used indanger-swift-with-swiftlint
docker container.