-
Notifications
You must be signed in to change notification settings - Fork 16
Pyscopg3 port #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyscopg3 port #38
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
01445ba
to
40dc2f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- setup.cfg: Language not supported
- tox.ini: Language not supported
channels_postgres/core.py
Outdated
message = (base64.b64decode(base64_message),) | ||
if float(timestamp) < time.time(): | ||
continue | ||
message = (base64.b64decode(base64_message),) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base64 decoding of 'base64_message' is performed twice consecutively in the '_get_message_from_channel' method. Consider decoding once and reusing the result to improve efficiency.
message = (base64.b64decode(base64_message),) | |
if float(timestamp) < time.time(): | |
continue | |
message = (base64.b64decode(base64_message),) | |
decoded_message = base64.b64decode(base64_message) | |
message = (decoded_message,) | |
if float(timestamp) < time.time(): | |
continue | |
message = (decoded_message,) |
Copilot uses AI. Check for mistakes.
TODO
aiopg
withpyscopg3
setup.py
withpyproject.toml
pylint
andmypy
pylint
andmypy