Skip to content

Conversation

Miggleness
Copy link
Contributor

@Miggleness Miggleness commented Jul 10, 2018

This PR is to address #153 which exposes the WorkflowInstance's 'Reference' property.

Notes:

  • A number of unit tests are failing from my end prior to change, I didn't bother with those. I'm using Rider 2018.1 on Mac.
  • Regarding placement of "Reference" argument in StartWorkflow(). The current placement feels awkward, but it sets up for slightly better compatibility. Preferably, the sequence will be (id, version, reference, data)
  • I'm considering updating model builder to index 'Reference'. But then, probably better to let the end users decide on that.

Copy link
Owner

@danielgerlag danielgerlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you also increment the version number?

host.Start();

host.StartWorkflow("Simple Decision Workflow", 1, null);
host.StartWorkflow("Simple Decision Workflow", 1, null, null);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify all the samples to just use host.StartWorkflow(name)?

@Miggleness
Copy link
Contributor Author

done :)

Any chance you're upgrading the samples to dotnet core 2.1.1? For some odd reason, my Mac won't run the 1.x SDK installers.

@danielgerlag danielgerlag merged commit 894398a into danielgerlag:master Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants