Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease of use of commands #39

Closed
AsafMag opened this issue Aug 15, 2018 · 1 comment
Closed

Ease of use of commands #39

AsafMag opened this issue Aug 15, 2018 · 1 comment
Assignees

Comments

@AsafMag
Copy link

AsafMag commented Aug 15, 2018

There are 2 things that I feel are must have to make a greater ease of use:

  1. tag parameter could be added to all commands - sync and async as one. This is because I use multiple synchronous commands at the same time across multiple threads and their results always clash.
  2. Async commands could launch an event on ApiDoneSentence arrival - so I could clean up easily without looping over command.IsRunning.

Could you do that? :)

@danikf
Copy link
Owner

danikf commented Aug 17, 2018

Hi,

1 - tik4net is not guaranteed to be thraed safe. I would recommend connection per thread. But for this behavior - I am planning to add some kind of .WithTag or connection.SendTagAlways options in the next release.
2 - I aggree with your idea. Thanks.

D

@danikf danikf self-assigned this Aug 17, 2018
danikf added a commit that referenced this issue Sep 1, 2018
+ New WirelessChannels, WirelessSniffer classes provied by AsafMag #40
danikf added a commit that referenced this issue Sep 2, 2018
danikf added a commit that referenced this issue Sep 3, 2018
@danikf danikf closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants