Fix locales with special dialogs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that dependencies have their own locale files, and this may explain why the load and save dialog on Microsoft Windows always used the English messages for the Cancel button, or why the About Dialog was not translated only on Microsoft Windows. This commit patches the msys-build.sh script so that third party locales are copied when creating a binary distribution for Microsoft Windows. This commit also patches main.rs so that when running the application on Windows, libadwaita is rebound again to the proper directory, for reasons stated in the comment I've added on top of the block.
It turns out that I forgot to add this file to the POTFILES, therefore the commands would never pick the strings in this file in first place, so they are always presented in English.
Same thing, the locales have to be packed so that it works without Homebrew installed because apparently libadwaita also hardcodes the path there (I suppose that it is hardcoded to /opt/homebrew/share/locale).
danirod
added
the
Pending backport
Phosphorus-M
pushed a commit
to Phosphorus-M/cartero
that referenced
this pull request
Sep 8, 2024
Fix locales with special dialogs
danirod
removed
the
Pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dialogs were not being translated and in this PR I add fixes for that.