Skip to content

Conversation

stefanvanherwijnen
Copy link
Contributor

#65

@coveralls
Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 8193371 on stefanvanherwijnen:transform into 17b85e0 on danivek:master.

@mattiloh
Copy link
Collaborator

Thanks for the PR @stefanvanherwijnen! It looks like some tests are failing. Apart from that, it would be great to add a test to assert, that the deserialize function is used as expected.
Can you update this PR accordingly?

@stefanvanherwijnen
Copy link
Contributor Author

Yep, sorry for not checking the tests...
Actually had to refactor it because I thought some neat nested ternary expression solution would be ok, but the linter did not agree with me 😅 .

@danivek
Copy link
Owner

danivek commented Apr 15, 2019

Thanks for the PR @stefanvanherwijnen! Can you add some words about it on README, and it would be ok to merge.

Add deserialize function documentation.
@danivek danivek merged commit 9e7fec9 into danivek:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants