Skip to content

Add missing rebinding trait to TaggedAllocator #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing rebinding trait to TaggedAllocator #5015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/smallvector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ struct TaggedAllocator : std::allocator<T>
TaggedAllocator(Ts&&... ts)
: std::allocator<T>(std::forward<Ts>(ts)...)
{}

template<class U>
TaggedAllocator(const TaggedAllocator<U, N>);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this constructor has no implementation right? Should it be marked with =delete?

Copy link
Owner

@danmar danmar May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it but I wonder if this constructor should be removed and let the other constructor be used instead. What happens if you comment out line 45 and 46 and recompile?


template<class U>
struct rebind
{
using other = TaggedAllocator<U, N>;
};
};

template<typename T, std::size_t N = DefaultSmallVectorSize>
Expand Down