bump package version; add rc.13 support #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
LGTM! The tests aren't passing in CI, but it's passing locally... strange. Maybe try and re-run @jellegerbrandy? It's one of the pesky competition tests that I've found to be inconsistent.
jellegerbrandy
added a commit
that referenced
this pull request
May 5, 2020
* [WIP] Modelling separate schemes, proposals and other entities * [WIP] Proposal does not depend on Plugin type * [WIP] Generic Scheme progress * More progess and corrections on GenericScheme * use migration-experimental * read updates * docs updated * test fix * Scheme and Proposal search, and type specific itemMaps implemented * [WIP] Better and dynamic use of fragments * init * State implemented for GenericScheme and name fixes * Various fixes + Vote and Stake added * Turned proposal fields into EntityRefs * Logger and Tag added * [WIP] Detemplatized ProposalPlugin and added Queue and DAO * Reward, Reputation and Settings added * [WIP] All remaining entities added * [WIP] Organizing classes: fields, constructor, static, read, write * review comments * test addresses + begin version fixes * all tests almost passing * ItemMap base abstraction and SchemeRegistrar added * ContributionReward and UGenericScheme + small refactor * tests passing * remove comment * revert doc updates * package-lock updates * Competition suggestion and vote added. All schemes except competition * test-env 4.0.2 * wait for subgraph * sleep longer? * sleep * sleep longer :/ * wait script * remove test logging * fix * fix error message * handle startup log * executable shell script * new scaffolding * linter fix * Competition added * TS and Linter fixes. New folder replaced old src * Renamed scheme to plugin everywhere except queries, results and names * Dynamic querying of proposals and plugin fragment fixes * General cleanup * fix compiler errors * Minor fixes * Eliminated boilerplate constructors and itemMap wrappers * Arc getABI function signature changed. Handler for all params missing * Templatized plugin and proposal with states. Eliminated UGS * Extra constructors deleted and linter fix * Added missing proposal methods, templatized create proposal, tests prog * [WIP] progress on test updates * Plugin calculateID method. Dao createProposal mehtod simplified * Proposal is now created in dao.createProposal * Typedefs for anyProposal, anyPlugin and anyProposalPlugin * change name and version * simplifying imports * Simplified imports * [WIP] Progress on tests and fixes * sleep 120 * Tests migrated (untested) * Minor fix on fetchState for plugins * Export for reputationFromToken Scheme * import changes * Merge fixes * merge fixes (no universal schemes + scheme params) * experimental merge fix * ProposalName fix * rollup working * static baseFragment getter * Static getters instead of fields * Access modifiers explicit * ProposalPlugins and Plugin both implemented in DAO. Query still missing * Query gets passed down to ItemMap for better error message with query * wait-for-subgraph.sh * trying to debug * test w/ dorgtech images * postgres logs * Fixed dependencies issue. Arc tests working * daostack docker images * dorgtech images * remove logging * fix * remove non-existent proposal types * itemMaps now return states instead of entities * change query * Wrappers for search itemMappers and fetchAll is new default * Competition Plugin no longer extends CRExt. Progress on tests * fix test * Votes now part of proposal state and query. Progress on tests * Competition fixes. Test progress * update docker images + regen docs * update graph-node * version bump * IArcOptions * remove web3Provider unused property * better typing * custom signer * version bump * web3 client + provider getters * Progress on tests. Mapped 'SchemeRegistrar' type to its proposal type * rebranding to arc.js (#449) * rebranding to arc.js * update docs * Unknown Plugin created. 25 tests to go * FetchAll condition eliminated. FetchState throws if found null * testing * lint fixes * getDefaultAddress(): string * cache.spec.ts working * token no contract fix * proposal.spec.ts passing * Proposal-stake tests fixed * proposal-execute.spec.ts working * queue.spec.ts working * dao fix * proposal-claim-reward.spec.ts working * SchemeRegistrar test fixes * init * Plugin base itemMap. ReputationFromToken now a plugin * Package json fix * Proposal competition test fixes * fix test * competition update * No more console.log. Replaced for logger * Linter fixes * IProposalType param removed. Proposal test bug fix * bump package version; add rc.13 support (#452) * bump package version; add rc.13 support * use latest version numbers for tests * Optional plugin param in createProposal options * Merge fixes * Member createdAt field added and tested * competition fix * linter fixes * fix dao.createProposal test * fix error * add competition suggestions back into the cache * linter fix * removing parallel cache manip tests * fix * skipping cache manip tests * export IEntityState * Doc, demojs and tsconfig updates * NoImplicit any flag enabled * Operation minor test fix * grammar updates + test cov * Removed unnecessary semicolons, appended 'Plugin' to all plugin classes * Queried ID passed to ItemMaps instead of query, for better error msgs * Arc client options interface * Dev docs, fragment cleanup and renaming 'scheme' to 'plugin' * Linter fixes Co-authored-by: Nestor Amesty <nestor09amesty@gmail.com> Co-authored-by: dOrgJelli <jelli@dorg.tech> Co-authored-by: Jordan Ellis <5522128+dOrgJelli@users.noreply.github.com> Co-authored-by: orenyodfat <orenyodfat@users.noreply.github.com>
jellegerbrandy
added a commit
that referenced
this pull request
May 12, 2020
* [WIP] Modelling separate schemes, proposals and other entities * [WIP] Proposal does not depend on Plugin type * [WIP] Generic Scheme progress * More progess and corrections on GenericScheme * use migration-experimental * read updates * docs updated * test fix * Scheme and Proposal search, and type specific itemMaps implemented * [WIP] Better and dynamic use of fragments * init * State implemented for GenericScheme and name fixes * Various fixes + Vote and Stake added * Turned proposal fields into EntityRefs * Logger and Tag added * [WIP] Detemplatized ProposalPlugin and added Queue and DAO * Reward, Reputation and Settings added * [WIP] All remaining entities added * [WIP] Organizing classes: fields, constructor, static, read, write * review comments * test addresses + begin version fixes * all tests almost passing * ItemMap base abstraction and SchemeRegistrar added * ContributionReward and UGenericScheme + small refactor * tests passing * remove comment * revert doc updates * package-lock updates * Competition suggestion and vote added. All schemes except competition * test-env 4.0.2 * wait for subgraph * sleep longer? * sleep * sleep longer :/ * wait script * remove test logging * fix * fix error message * handle startup log * executable shell script * new scaffolding * linter fix * Competition added * TS and Linter fixes. New folder replaced old src * Renamed scheme to plugin everywhere except queries, results and names * Dynamic querying of proposals and plugin fragment fixes * General cleanup * fix compiler errors * Minor fixes * Eliminated boilerplate constructors and itemMap wrappers * Arc getABI function signature changed. Handler for all params missing * Templatized plugin and proposal with states. Eliminated UGS * Extra constructors deleted and linter fix * Added missing proposal methods, templatized create proposal, tests prog * [WIP] progress on test updates * Plugin calculateID method. Dao createProposal mehtod simplified * Proposal is now created in dao.createProposal * Typedefs for anyProposal, anyPlugin and anyProposalPlugin * change name and version * simplifying imports * Simplified imports * [WIP] Progress on tests and fixes * sleep 120 * Tests migrated (untested) * Minor fix on fetchState for plugins * Export for reputationFromToken Scheme * import changes * Merge fixes * merge fixes (no universal schemes + scheme params) * experimental merge fix * ProposalName fix * rollup working * static baseFragment getter * Static getters instead of fields * Access modifiers explicit * ProposalPlugins and Plugin both implemented in DAO. Query still missing * Query gets passed down to ItemMap for better error message with query * wait-for-subgraph.sh * trying to debug * test w/ dorgtech images * postgres logs * Fixed dependencies issue. Arc tests working * daostack docker images * dorgtech images * remove logging * fix * remove non-existent proposal types * itemMaps now return states instead of entities * change query * Wrappers for search itemMappers and fetchAll is new default * Competition Plugin no longer extends CRExt. Progress on tests * fix test * Votes now part of proposal state and query. Progress on tests * Competition fixes. Test progress * update docker images + regen docs * update graph-node * version bump * IArcOptions * remove web3Provider unused property * better typing * custom signer * version bump * web3 client + provider getters * Progress on tests. Mapped 'SchemeRegistrar' type to its proposal type * rebranding to arc.js (#449) * rebranding to arc.js * update docs * Unknown Plugin created. 25 tests to go * FetchAll condition eliminated. FetchState throws if found null * testing * lint fixes * getDefaultAddress(): string * cache.spec.ts working * token no contract fix * proposal.spec.ts passing * Proposal-stake tests fixed * proposal-execute.spec.ts working * queue.spec.ts working * dao fix * proposal-claim-reward.spec.ts working * SchemeRegistrar test fixes * init * Plugin base itemMap. ReputationFromToken now a plugin * Package json fix * Proposal competition test fixes * fix test * competition update * No more console.log. Replaced for logger * Linter fixes * IProposalType param removed. Proposal test bug fix * bump package version; add rc.13 support (#452) * bump package version; add rc.13 support * use latest version numbers for tests * Optional plugin param in createProposal options * Merge fixes * Member createdAt field added and tested * competition fix * linter fixes * fix dao.createProposal test * fix error * add competition suggestions back into the cache * linter fix * removing parallel cache manip tests * fix * skipping cache manip tests * export IEntityState * Doc, demojs and tsconfig updates * NoImplicit any flag enabled * Operation minor test fix * grammar updates + test cov * Removed unnecessary semicolons, appended 'Plugin' to all plugin classes * Queried ID passed to ItemMaps instead of query, for better error msgs * Arc client options interface * Dev docs, fragment cleanup and renaming 'scheme' to 'plugin' * Linter fixes * [WIP] PluginManager and tests * [WIP] PluginManager Add Test working * All tests working. Replaced plugin not being removed * Replace test still failing * Minor fix for plugin options parameter. Already fixed in main branch * test fix * Remove SchemeRegistrarEdit * update package-lock.json * linter fixes * use @daostack/test-env-experimental * Merge fixes for schemefactory * Linter fixes * dao.proposal and dao.plugin shorthands added * Single plugin and proposal search shorthands * dao.proposal(...) fix * Plugin and Proposal static create, with tests * version bump Co-authored-by: dOrgJelli <jelli@dorg.tech> Co-authored-by: Jordan Ellis <5522128+dOrgJelli@users.noreply.github.com> Co-authored-by: Jelle Gerbrandy <jellegerbrandy@gmail.com> Co-authored-by: orenyodfat <orenyodfat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.