Skip to content

Eliminate unnecessary web socket calls #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 29, 2020
Merged

Eliminate unnecessary web socket calls #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
679ca75
Package version 0.2.81
roienatan Dec 27, 2020
c35eb1f
stop calling unnecessary calls to wss
roienatan Dec 29, 2020
6af4b3e
fix lint
roienatan Dec 29, 2020
1f94496
add comment
roienatan Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@daostack/arc.js",
"version": "0.2.81",
"version": "0.2.82",
"description": "",
"keywords": [],
"main": "dist/lib/index.js",
Expand Down
5 changes: 4 additions & 1 deletion src/graphnode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,12 @@ export function createApolloClient(options: {
uri: options.graphqlHttpProvider
})

// 'lazy: true' and 'reconnect: false' are temporary fixes to avoid unnecessary web socket calls from the graph.
// See https://github.com/daostack/arc.js/pull/573
const wsLink = new WebSocketLink({
options: {
reconnect: true
lazy: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lazy should be set to false https://github.com/apollographql/subscriptions-transport-ws/blob/2b0eefa438409263d0e38e3a39d062e3def41218/README.md#subscriptionclient

reconnect: false
},
uri: options.graphqlWsProvider,
webSocketImpl: WebSocket
Expand Down