Skip to content

address audit report #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2020
Merged

address audit report #711

merged 2 commits into from
Feb 6, 2020

Conversation

orenyodfat
Copy link
Contributor

No description provided.

@orenyodfat orenyodfat requested a review from leviadam as a code owner February 5, 2020 21:43
ben-kaufman
ben-kaufman approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

address audit report
d7cfa24 
test

voting machine cannot be zero

initilized local vars

bump version
dkent600
dkent600 suggested changes Feb 6, 2020
View reviewed changes
@orenyodfat orenyodfat merged commit 74946b8 into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellegerbrandy jellegerbrandy Awaiting requested review from jellegerbrandy

3 more reviewers

@dkent600 dkent600 dkent600 requested changes

@ben-kaufman ben-kaufman ben-kaufman approved these changes

@leviadam leviadam leviadam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orenyodfat @dkent600 @ben-kaufman @leviadam