Create Common - Prevent credit card payments of below $5

[gingervik]

The minimum contribution should be at least $5
DO NOT FORGET TO CHANGE WARNING MESSAGE ALSO
For this, we will split the current field of "Minimum contribution" into two fields.

On the "Minimum contribution" field, the minimum will be $5 (not $0 as it is today).

We also changed the title and text to match the new functionality.

In addition, we should add a new checkbox, for founders who want to allow members to join without a personal contribution. If this option is selected, the "minimum contribution" field will be disabled and set automatically for "5$".

!!!Remove Funds safety period section from common creation, and let anyone create proposals from day one.

1 - Create common - funding

2 - No-contribution members selected

3 - Error message for minimum contribution below $5

[alexander2001i]

@lpetkov-sw - The backend part of this PR is merged, ping me when you need it deployed

[kazaryan-t]

Tested on Staging iOS version 1.9.5 (4978-268)
Tested on Staging Android version 1.9.5 (4978-229)

There are some mismatches with the design:

1. We should add the word TYPE near the word Contribution
2. Delete (min. $5) and Required
3. Change the error when a user enters less than 5$ in the contribution field (it should be "The minimum contribution must be $5 or higher")
4. When the moderator of the common clicks on the checkbox (that allows members to join without a personal contribution), the contribution field should be inactive. - https://zpl.io/2p8d45Q

Design -

Actual -

[watchtower314]

@Taikaish I have a question about the limit of the funding, right now for one-time it's between $5-$3000, and for monthly it's $5-$500, but the design doesn't have that anymore, so should I remove this at all, or we still need this?

[watchtower314]

@kazaryan-t what about monthly contribution?
this is how it looks when I change the error message:

[watchtower314]

@kazaryan-t I spoke with Tai, regarding the upper limit, we still need to have this error message for amount that is greater than the correct max contributio:
(max for one-time contribution should be $3000 and for monthly, it's $500)

monthly

one-time

[watchtower314]

What to test:

• allow users to join without contribution: only FOR ONE-TIME contribution
• remove (min $5) from title, and remove required

- add `type` to title

[kazaryan-t]

Tested on Staging Android version 1.9.6 (6433-233)

Strange behavior of the contribution field on the Funding page

Steps to reproduce:

1. Start to create a Common
2. On the Funding page click on the checkbox "Let users join the Common without a personal contribution"
3. Click on the checkbox one more time
4. Try to insert an amount
5. Click on the back arrow
6. Click on Continue to Funding button

Actual:

• The text "Minimum one-time contribution" disappears
• Impossible to insert the amount to the amount field
• Incorrect amount appears after clicking back and returning to the Funding page

Screen_Recording_20210419-195649_common-stg.mp4