Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kombu client hanging bug fixed #76

Merged
merged 1 commit into from
May 22, 2022
Merged

kombu client hanging bug fixed #76

merged 1 commit into from
May 22, 2022

Conversation

dapper91
Copy link
Owner

@dapper91 dapper91 commented May 22, 2022

Reason: kombu client creates a response queue implicitly after a request has been sent to the server. If the server finishes handling the request before the response queue is created then the response message will be lost. In such case the client hangs forever waiting for the response from the server.

Solution: This fix forces the client to create the response queue explicitly just before the request is sent which prevents the response message from being lost.

Issue: #66

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #76 (08cbe2a) into dev (8d86b55) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #76      +/-   ##
==========================================
- Coverage   78.74%   78.71%   -0.04%     
==========================================
  Files          40       40              
  Lines        2583     2584       +1     
==========================================
  Hits         2034     2034              
- Misses        549      550       +1     
Flag Coverage Δ
unittests 78.71% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pjrpc/client/backend/kombu.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d86b55...08cbe2a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sudden hang when examples/kombu_server.py and kombu_client.py communicate.
2 participants