Standardjson #569

MrChico · 2020-12-10T12:25:39Z

Addresses #168, #572 and accommodates for Solidity deprecating --combined-json.
Refactors build-dapp-package.nix to use dapp-build instead of handcrafted solc invocation.
Some TODOs, might be more things that I have not yet thought of:

dapp create
dapp --make-library-state.
seth combined-json & seth bundle-source
- fixed and renamed to seth solc
- make bundle-source work with a standard json etherscan example
  ~~- [ ] hevm needs to interpret the sources in more detail, differentiating between "urls" and "content"~~
  ~~- [ ] then we can check that seth run-tx/debug work against both flattened and standard json examples~~
  EDIT: url and content is not available in the compiler output, we would need to parse the input file as well. Postponing this.
dapp build could interpret and render the solc errors in the json

rainbreak · 2020-12-10T13:57:16Z

src/dapp/libexec/dapp/dapp---find-libraries

 mapfile -t sources < <(find "${DAPP_SRC?}" "$DAPP_LIB" -name '*.sol')
 grep -EH '^library\s+\w+' "${sources[@]}" \
  | sed -E 's/:library[[:blank:]]+([_[:alnum:]]+)[[:blank:]]+(\{|is).*/:\1/' \
  | sort | while read -r line; do
-    # Only include libraries that have actually been built.
-    if [[ -f $(binfile <<<"$line") ]]; then echo "$line"; fi
+    echo "$line";


have you tested this with some projects that use libraries?

Only a toy example, which I will add to dapp-test. Still needs --make-library-state to work tho

src/dapp/libexec/dapp/dapp-build

src/dapp/libexec/dapp/dapp-mk-standard-json

rainbreak · 2020-12-10T14:02:10Z

src/dapp/resources/jsontemplate.json

+    "evmVersion": "byzantium",
+    // Optional: Change compilation pipeline to go through the Yul intermediate representation.
+    // This is a highly EXPERIMENTAL feature, not to be used for production. This is false by default.
+    "viaIR": true,


Should we set these to sane defaults and then actually use them rather than popping?

Maybe... The template right now is mainly used to be informative and demonstrate the capabilities of the std json.

One problem would be compatibility with older solc versions. Are options just ignored if they aren't used by solc? The evmVersion could be especially problematic, does solc just fill this with a default if you don't supply it?

src/dapp/libexec/dapp/dapp-mk-standard-json

src/hevm/src/EVM/Solidity.hs

src/dapp/libexec/dapp/dapp-build

Co-authored-by: rain <rainbreak@riseup.net>

instead of handcrafted building script A few minor tweaks to `dapp-build` and `dapp-mk-standard-json`

We have to specify gas prices like `seth --gas-price 100gwei` as we can't have spaces in these arguments, unless we provide a quoted argument like `seth --gas-price "100 gwei"`.

introduces the implicit parameter DappContext, which can be used in `showAbiValue` to e.g. render addresses with their contract name. We now render addresses as `ContractName@0x....` when the address is associated with a contract and a name, and `@0x...` otherwise.

This allows us to create the build artefacts for contracts on etherscan that have been verified by the standard json method (as opposed to the flattened file method). N.B. hevm does not actually support this yet as it does not interpret the "content" field in the sources

MrChico · 2021-01-04T18:48:21Z

This is starting to get pretty ready. It's a fairly broad change, so I would like to see this get some testing before we make a release out of this. But things seem to work quite well now, might even be a bit more robust when it comes to libraries.

MrChico · 2021-01-05T15:09:01Z

Actually, the data we need to find the sources from the json output are available in the metadata section

MrChico · 2021-01-07T12:37:04Z

This now also supports hevm parsing of file content embedded directly in the standard json. Only missing now is support for standard json in seth bundle-source, but that could also wait until a future PR

ethernomad · 2021-01-08T08:23:36Z

I can test pragma solidity ^0.8.0; code with this branch.

src/dapp/CHANGELOG.md

src/dapp/libexec/dapp/dapp---make-library-state

d-xo · 2021-01-07T15:20:21Z

src/dapp/libexec/dapp/dapp-build

+###              files from the solc json into $DAPP_OUT. Beware of contract
+###              name collisions. This is provided for compatibility with older
+###              workflows.
+###  --optimize: activate the solidity optimizer.


should we allow users to specify the runs from the command line as well?

src/dapp/libexec/dapp/dapp-build

src/hevm/src/EVM/Format.hs

Co-authored-by: David Terry <xwvvvvwx@users.noreply.github.com>

MrChico · 2021-01-11T10:13:12Z

src/dapp/CHANGELOG.md

+- `SOLC_FLAGS`. To modify the compiler settings, use a custom standard json and set 
+the filename as argument to `DAPP_STANDARD_JSON`.


Suggested change

- `SOLC_FLAGS`. To modify the compiler settings, use a custom standard json and set

the filename as argument to `DAPP_STANDARD_JSON`.

- `SOLC_FLAGS`. To modify the compiler settings, use `--optimize` or set `DAPP_STANDARD_JSON` to the location of a hand written standard json.

src/dapp/README.md

Co-authored-by: David Terry <xwvvvvwx@users.noreply.github.com>

MrChico · 2021-01-11T11:22:33Z

I say we merge this and try it out on master for a bit before release

MrChico · 2021-01-12T12:07:59Z

~~hmm, I think dapp create is still needed~~, no it seems fine

MrChico requested a review from rainbreak December 10, 2020 12:25

rainbreak reviewed Dec 10, 2020

View reviewed changes

src/dapp/libexec/dapp/dapp-build Show resolved Hide resolved

rainbreak reviewed Dec 10, 2020

View reviewed changes

src/dapp/libexec/dapp/dapp-mk-standard-json Outdated Show resolved Hide resolved

rainbreak reviewed Dec 10, 2020

View reviewed changes

src/dapp/libexec/dapp/dapp-mk-standard-json Outdated Show resolved Hide resolved

rainbreak reviewed Dec 10, 2020

View reviewed changes

src/hevm/src/EVM/Solidity.hs Show resolved Hide resolved

MrChico added 7 commits December 14, 2020 17:40

WIP: dapp build w standard-json

4fa7860

wip

606e412

parsing of std json format

1c70b12

dapp-build: fail on critical errs, prettier printing

8581171

dapp build; more modular approach to building and configuring std-json

224f541

add missing jsontemplate

f20c302

adapt make-library-state to std json format

9626f23

MrChico force-pushed the standardjson branch from 7a06892 to 9626f23 Compare December 14, 2020 20:11

MrChico and others added 3 commits December 14, 2020 22:55

changelog updates

b38e1fb

seth: use standard json in seth debug

cc6ad36

fix dapp --make-library-state

73034cd

This was linked to issues Dec 15, 2020

Output compact AST when running dapp build #168

Closed

hevm pretty prints address arguments with leading zeros missing #572

Closed

fix address pretty printing

039f0fb

MrChico force-pushed the standardjson branch from fa9870b to 039f0fb Compare December 16, 2020 11:58

rainbreak reviewed Dec 16, 2020

View reviewed changes

src/dapp/libexec/dapp/dapp-build Outdated Show resolved Hide resolved

MrChico and others added 7 commits December 16, 2020 13:27

Update src/dapp/libexec/dapp/dapp-build

0916936

Co-authored-by: rain <rainbreak@riseup.net>

refactor build-dapp-package.nix to use dapp

e503d93

instead of handcrafted building script A few minor tweaks to `dapp-build` and `dapp-mk-standard-json`

add library test

b772c5e

seth-solc: doc and pretty print

b410f06

seth: check --from addresses, allow gwei gas prices

2708169

We have to specify gas prices like `seth --gas-price 100gwei` as we can't have spaces in these arguments, unless we provide a quoted argument like `seth --gas-price "100 gwei"`.

MrChico added 8 commits January 4, 2021 11:43

make sure to pass dappFlags

14facaa

fix library setup

d9348c2

ensure building happens despite empty libraries

3640378

make dummy git user for dapp tests

73f29c5

shellcheck

a87acb2

solc 0.8.0 compatible

5919d08

commit shenanegans

9f39a23

ignore source files we cannot find

eb05976

MrChico marked this pull request as ready for review January 4, 2021 18:45

MrChico requested a review from d-xo January 4, 2021 18:48

support contents embedded in standard json

e91df4d

MrChico mentioned this pull request Jan 7, 2021

Solc 0.8.0 support? #578

Closed

d-xo reviewed Jan 8, 2021

View reviewed changes

MrChico commented Jan 8, 2021

View reviewed changes

src/hevm/src/EVM/Format.hs Outdated Show resolved Hide resolved

MrChico and others added 2 commits January 8, 2021 13:42

Apply suggestions from code review

48b71e4

Co-authored-by: David Terry <xwvvvvwx@users.noreply.github.com>

Update src/dapp/libexec/dapp/dapp-build

527e828

MrChico commented Jan 11, 2021

View reviewed changes

src/dapp/README.md Outdated Show resolved Hide resolved

Update src/dapp/README.md

4ac2348

d-xo reviewed Jan 11, 2021

View reviewed changes

src/dapp/README.md Outdated Show resolved Hide resolved

Update src/dapp/README.md

96de551

Co-authored-by: David Terry <xwvvvvwx@users.noreply.github.com>

MrChico merged commit a418e00 into master Jan 11, 2021

MrChico deleted the standardjson branch January 11, 2021 11:28

MrChico mentioned this pull request Jan 12, 2021

[CLI] Drop --combined-json option and direct users to standard json ethereum/solidity#10278

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standardjson #569

Standardjson #569

MrChico commented Dec 10, 2020 •

edited

Loading

rainbreak Dec 10, 2020

MrChico Dec 10, 2020

rainbreak Dec 10, 2020

MrChico Dec 10, 2020

rainbreak Dec 10, 2020

MrChico commented Jan 4, 2021

MrChico commented Jan 5, 2021

MrChico commented Jan 7, 2021

ethernomad commented Jan 8, 2021

d-xo Jan 7, 2021

MrChico Jan 11, 2021

MrChico commented Jan 11, 2021

MrChico commented Jan 12, 2021 •

edited

Loading

		- `SOLC_FLAGS`. To modify the compiler settings, use a custom standard json and set
		the filename as argument to `DAPP_STANDARD_JSON`.

Standardjson #569

Standardjson #569

Conversation

MrChico commented Dec 10, 2020 • edited Loading

rainbreak Dec 10, 2020

Choose a reason for hiding this comment

MrChico Dec 10, 2020

Choose a reason for hiding this comment

rainbreak Dec 10, 2020

Choose a reason for hiding this comment

MrChico Dec 10, 2020

Choose a reason for hiding this comment

rainbreak Dec 10, 2020

Choose a reason for hiding this comment

MrChico commented Jan 4, 2021

MrChico commented Jan 5, 2021

MrChico commented Jan 7, 2021

ethernomad commented Jan 8, 2021

d-xo Jan 7, 2021

Choose a reason for hiding this comment

MrChico Jan 11, 2021

Choose a reason for hiding this comment

MrChico commented Jan 11, 2021

MrChico commented Jan 12, 2021 • edited Loading

MrChico commented Dec 10, 2020 •

edited

Loading

MrChico commented Jan 12, 2021 •

edited

Loading