Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when consul is used as a name resolution component problem #1793

Closed
wants to merge 25 commits into from
Closed

fix when consul is used as a name resolution component problem #1793

wants to merge 25 commits into from

Commits on Jun 20, 2022

  1. Add contexts to pubsub.Subscribe to allow early cancelation (#1756)

    This commit is related to dapr/dapr#4624. As noted there, we have an issue in the runtime where all components are shut down after the grace period, when the app is likely already stopped. Because of that, certain input components (the subscribe part of pubsub and the input part of bindings - the latter not in scope of this PR), can continue bringing new work when it's known to fail.
    
    In order to fix the issue linked above properly, we need to implement a way for PubSub components to have the "publish" part closed before the "subscribe" one (and in the future that will need to be done for input bindings too).
    
    This commit achieves precisely that by adding a context in the Subscribe method. When that context is canceled (which can be at any time), the subscription is removed.
    
    PS: This API change was implemented so it can one day be used for dapr/dapr#814 too, as it allows canceling individual subscriptions by using a different context. Although that's not possible today because it requires more work on the runtime, it does implement everything that's needed in the pubsub components already.
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    ItalyPaleAle authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    434e3fc View commit details
    Browse the repository at this point in the history
  2. fix:Use the id to distinguish

    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    guozy66 authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    4979bcc View commit details
    Browse the repository at this point in the history
  3. perf: id

    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    guozy66 authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    66e6946 View commit details
    Browse the repository at this point in the history
  4. Bumped dapr/dapr in cert tests (#1773)

    * Bumped dapr/dapr in cert tests
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Updated interface
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Added missing go.mod
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * More fixes
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Fix eventhubs not closing on context cancelation
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    ItalyPaleAle authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    b16fdcd View commit details
    Browse the repository at this point in the history
  5. adding query api to the feature list (#1775)

    Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
    
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    0765196 View commit details
    Browse the repository at this point in the history
  6. Updated sendgrid binding to add the option to add names for the to an… (

    #1751)
    
    * Updated sendgrid binding to add the option to add names for the to and from addresses. This commit relates to #1749
    
    Signed-off-by: Adam Rahja <adam@resolve.com>
    
    * Updated sendgrid binding from code suggestion.
    
    Signed-off-by: Adam Rahja <adam@resolve.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    arahja authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    6fb4e92 View commit details
    Browse the repository at this point in the history
  7. Add Redis StateStore Certification Tests (#1763)

    * Add redis certification test
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    * Adding Test Plan in ReadMe
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    * Adding redis state cert test to workflow
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    * Overwrite open telemetry dependency
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c448211 View commit details
    Browse the repository at this point in the history
  8. Add additional Event Hub topics for certification tests (#1767)

    * Add additional Event Hub topics for certification tests
    
    Signed-off-by: GitHub <noreply@github.com>
    
    * Apply EventHubs changes for pubsub and binding cert tests
    
    Signed-off-by: GitHub <noreply@github.com>
    
    * Remove partitions from EHs because we don't want to pay for premium
    
    Signed-off-by: GitHub <noreply@github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    berndverst authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    9667b19 View commit details
    Browse the repository at this point in the history
  9. Add postgresql certification test + connection idle time (#1778)

    * Add postgresql certification test + connection idle time
    
    Signed-off-by: yaron2 <schneider.yaron@live.com>
    
    * change flow name
    
    Signed-off-by: yaron2 <schneider.yaron@live.com>
    
    * go mod tidy
    
    Signed-off-by: yaron2 <schneider.yaron@live.com>
    
    * add to workflow
    
    Signed-off-by: yaron2 <schneider.yaron@live.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    yaron2 authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    1ea3cf4 View commit details
    Browse the repository at this point in the history
  10. fix: dubbo binding enhancement (#1782)

    * fix: dubbo binding enhancement
    
    Signed-off-by: LaurenceLiZhixin <382673304@qq.com>
    
    * fix: tidy all
    
    Signed-off-by: LaurenceLiZhixin <382673304@qq.com>
    
    * mod tidy
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Pin couchbaselabs/gojcbmock to commit with LICENSE
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * modtidy again
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * commit to retrigger tests
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    44c1e40 View commit details
    Browse the repository at this point in the history
  11. Rabbitmq publisher confirm (#1762)

    * Added `publishConfirm` option to RabbitMQ
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Changed to publisherConfirm per feedback
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    3 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    6794528 View commit details
    Browse the repository at this point in the history
  12. Bump github.com/open-policy-agent/opa from 0.23.2 to 0.40.0 (#1757)

    * Bump github.com/open-policy-agent/opa from 0.23.2 to 0.40.0
    
    Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.23.2 to 0.40.0.
    - [Release notes](https://github.com/open-policy-agent/opa/releases)
    - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md)
    - [Commits](open-policy-agent/opa@v0.23.2...v0.40.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/open-policy-agent/opa
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    * Update go mods
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    834bad8 View commit details
    Browse the repository at this point in the history
  13. Make Service Bus attempt to reconnect forever in case of issues (#1783)

    * Make Service Bus attempt to reconnect forever in case of issues
    
    With exponential back-off configurable between min and max time. Fixes #1612
    
    Also includes fixes:
    
    - Binding: make sure it actually retries to connect forever
    - Binding: add delay (exponential backoff) before reconnecting
    - PubSub: better handling of failures such as topics disabled or other non-connection issues
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * 💄
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Added warning for deprecated metadata options
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * 💄
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    ItalyPaleAle authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    d82282e View commit details
    Browse the repository at this point in the history
  14. [pubsub][rabbitmq]add support for binding multiple routingkeys at the…

    … same time (#1750)
    
    * Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * sort field
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * [pubsub]fix unit test bug
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * remove unrelated changes
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * Delete hard coded Metadata
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * remove  .history
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * restore .gitignore
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * fix code format
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * formatting code
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * [pubsub][rabbitmq]Add support for binding multiple routingkeys at the same time
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * add TestSubscribeBindRoutingKeys
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * fix: Infof to Debugf
    
    Signed-off-by: saberwang <saberwang@hotmail.com>
    
    * Update pubsub/rabbitmq/rabbitmq_test.go
    
    Co-authored-by: Looong Dai <long.dai@intel.com>
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    4 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    aa15e11 View commit details
    Browse the repository at this point in the history
  15. add file upload to s3 (#1785)

    Signed-off-by: yaron2 <schneider.yaron@live.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    yaron2 authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    a81cefd View commit details
    Browse the repository at this point in the history
  16. middleware: add wasm basic (#1747)

    * middleware: add wasm basic
    
    Signed-off-by: Loong <loong.dai@intel.com>
    
    * Update middleware/http/wasm/basic/basic.go
    
    * Update middleware/http/wasm/basic/basic.go
    
    Co-authored-by: Taction <zchao9100@gmail.com>
    Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    4 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    f9d07fb View commit details
    Browse the repository at this point in the history
  17. Upgrade Apache Dubbo again - pin to Dapr support branch (#1786)

    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    berndverst authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    751ad80 View commit details
    Browse the repository at this point in the history
  18. Adding Pinger interface and Removing mandatory nature of Ping fuction (

    …#1784)
    
    * add `Pinger` interface.
    
    Signed-off-by: chanyong.moon <dev.chanyongmoon@gmail.com>
    
    * Convert Ping fuction to optional
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    * Removing unrequired Ping implementations
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    * Addressing comments
    
    Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
    
    Co-authored-by: chanyong.moon <dev.chanyongmoon@gmail.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    ef54c4d View commit details
    Browse the repository at this point in the history
  19. Update to Camunda Platform 8 (#1787)

    Signed-off-by: Christian Kaps <ck-github@mohiva.com>
    
    Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    2 people authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    9a5d86c View commit details
    Browse the repository at this point in the history
  20. add json tags to lock requests/responses (#1788)

    Signed-off-by: yaron2 <schneider.yaron@live.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    yaron2 authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    48a3a1a View commit details
    Browse the repository at this point in the history
  21. Upgrade to Azure Table Storage Track 2 SDK in State Store and add Cos…

    …mosDB Table API support (#1792)
    
    * Upgrade to Azure Table Storage Track 2 SDK in State Store
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * make modtidy-all
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * don't panic
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * fix error parsing
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Adds support for empty rowKeys again
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Pin aztables v1.0.1
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Add support for Cosmos DB Table API
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Add Azure Table Storage CosmosDB conformance test
    
    Signed-off-by: GitHub <noreply@github.com>
    
    * Address code review
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Create Table Storage State store subtests
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Address linter issue
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * context instead of ctx
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * load state store in conf tests
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * use cosmosDB mode in cosmosDB test
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Add Azure AD support for Table Storage
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * remove shadow declaration
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * make accountKey optional
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * Add options to skip table creation
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    berndverst authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    efad4f0 View commit details
    Browse the repository at this point in the history
  22. Shared implementation for Azure Service Bus subscriptions for binding…

    … and pubsub (#1791)
    
    * Moved ASB subscription code to a shared package
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Moved ASBQ binding to use the shared ASB implementation
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Updating Azure Service Bus SDK version
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    ItalyPaleAle authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    0b4c1b3 View commit details
    Browse the repository at this point in the history
  23. update imports for Fossa and Certification test (#1796)

    * update imports for Fossa and Certification test
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    
    * modtidy
    
    Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
    Signed-off-by: wisdom 郭智勇 <guozy66@cn.midea.com>
    berndverst authored and wisdom 郭智勇 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    5468f87 View commit details
    Browse the repository at this point in the history
  24. lowcase id

    guozy66 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    ab18cc2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    1cdda68 View commit details
    Browse the repository at this point in the history