Fix regression in pubsub.kafka Avro message publication #4026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #4020 (Regression: pubsub.kafka component fails to publish Avro message in Dapr 1.16).
SchemaRegistryClient
.github.com/linkedin/goavro/v2
fromv2.13.1
tov2.14.0
to bring in the fix for Converting default value string of null to nil breaks legitimate schema. linkedin/goavro#280.This PR extends and replaces #4024.
Issue reference
#4020
Manual test results
useAvroJson
in pubsub.kafka component metadata controls JSON encoding of Avro messages (standard/Avro)excludeHeaderMetaRegex="^valueSchemaType$"
in pubsub.kafka component metadata allows dead-lettered Avro messages to be sent to a dead letter topic encoded as JSON, i.e. without inheriting thevalueSchemaType
metadata value of the original messageChecklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.