Skip to content

Conversation

nzkeith
Copy link
Contributor

@nzkeith nzkeith commented Sep 12, 2025

Description

Fix for #4020 (Regression: pubsub.kafka component fails to publish Avro message in Dapr 1.16).

This PR extends and replaces #4024.

Issue reference

#4020

Manual test results

  • useAvroJson in pubsub.kafka component metadata controls JSON encoding of Avro messages (standard/Avro)
  • Setting excludeHeaderMetaRegex="^valueSchemaType$" in pubsub.kafka component metadata allows dead-lettered Avro messages to be sent to a dead letter topic encoded as JSON, i.e. without inheriting the valueSchemaType metadata value of the original message
  • Sending a JSON message to a non-Avro topic succeeds

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation
    • Created the dapr/docs PR:

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

…1.16.

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
@nzkeith nzkeith requested review from a team as code owners September 12, 2025 08:30
@nzkeith nzkeith changed the title Fix/avro regression issue Fix regression in pubsub.kafka Avro message publication Sep 12, 2025
Signed-off-by: Keith Smith <19752063+nzkeith@users.noreply.github.com>
@nzkeith nzkeith force-pushed the fix/avro-regression-issue branch from 2f8daad to a9647dc Compare September 12, 2025 08:34
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yaron2 yaron2 merged commit 4fcfa7f into dapr:release-1.16 Sep 12, 2025
94 checks passed
passuied added a commit to passuied/components-contrib that referenced this pull request Sep 12, 2025
Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Signed-off-by: Keith Smith <19752063+nzkeith@users.noreply.github.com>
Co-authored-by: Patrick Assuied <patrick.assuied@elationhealth.com>
yaron2 added a commit that referenced this pull request Sep 15, 2025
…k to Main (#4026) (#4028)

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Signed-off-by: Keith Smith <19752063+nzkeith@users.noreply.github.com>
Co-authored-by: Keith Smith <19752063+nzkeith@users.noreply.github.com>
@jjcollinge jjcollinge mentioned this pull request Sep 24, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants