Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order-processor's app-port in java is not 6001 but 9001. #2537

Closed
wants to merge 45 commits into from

Conversation

YusukeTobo
Copy link

@YusukeTobo YusukeTobo commented Jun 19, 2022

In the following example, spring-boot http port is 9001.
https://github.com/dapr/quickstarts/blob/master/service_invocation/java/http/order-processor/src/main/resources/application.properties

server.port=${port:9001}

However, this tutorial's app-port is 6001.

dapr run --app-id order-processor --app-port 6001 --app-protocol http --dapr-http-port 3501 -- java -jar target/OrderProcessingService-0.0.1-SNAPSHOT.jar

Signed-off-by: Yusuke Tobo 46416479+YusukeTobo@users.noreply.github.com

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

willvelida and others added 30 commits March 21, 2022 20:04
…apr#2280)

Signed-off-by: Will Velida <willvelida@microsoft.com>
* Azure Key Vault RBAC role to get secrets updated
Signed-off-by: Sergio Velmay <sergiovelmay@gmail.com>

* Remove pin to localized version in MS link
Signed-off-by: Sergio Velmay <sergiovelmay@gmail.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Signed-off-by: Andrea Spadaccini <andrea.spadaccini@gmail.com>
I'm guessing it's a typo because the md file has the dash. But the command
itself doesn't

Signed-off-by: Doug Davis <dug@microsoft.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Minor updates to the golang pub-sub quickstart
- make the 'cd' command more clear by telling them to start from the clone
- add the sample output from the publisher

Signed-off-by: Doug Davis <dug@microsoft.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
…apr#2287)

* fix: Getting started / Init Dapr locally has wrong quickstarts link

Signed-off-by: Yauri<me@yauri-io>
Signed-off-by: y-io <me@yauri.one>

* Change Next Steps to "Use the Dapr API"

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>

* Update install-dapr-selfhost.md

Co-authored-by: y-io <me@yauri.one>
Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Kyle Richelhoff <1271617+grepme@users.noreply.github.com>
…apr#2303)

I followed the docs to ship Dapr together with an app inside the same container and came across the issue that `daprd` in the `ENTRYPOINT` was not available until i initialized dapr in slim mode.

Signed-off-by: Robin-Manuel Thiel <robin-manuel@thiel1.de>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
…apr#2263)

* adding Read buffer size argument to fasthttp server and grpc server dapr/dapr#3346

By making a contribution to this project, I certify that:
    (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
    (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
    (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
    (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

This is my commit message
Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* added introduction to dapr-http-read-buffer-size

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Modify the note description

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Adding read buffer size argument to fasthttp server and grpc server

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Added introduction to dapr-http-read-buffer-size

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Modify the note description

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Modify this description

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Add a detailed description

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Make the appropriate title changes

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

* Modification introduction and corresponding instructions

Signed-off-by: Fang Yuan <wojiushifangyuanlove@gmail.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms and others added 15 commits April 5, 2022 12:26
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Remove list of state stores & link to spec
I may have missed it but I couldn't find a way to go from the main README
(https://github.com/dapr/dapr) to the dev docs.

Signed-off-by: Doug Davis <dug@microsoft.com>
* link to repo; edit code snippet

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* remove first person; capitalize Quickstarts

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* capitalize quickstarts

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* remove first person

Signed-off-by: Hannah Hunter <hannahunter@microsoft.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
* Minor tweaks to the service invocation quickstart

Minor tweaks to the service invocation quickstart
- run the consumer before the sender, otherwise things will fail
- be clear about where to run the 'cd' cmd from
- in the golang sender sample code I removed the extra "if" statement
  because it wasn't relevant to the point being made... adding a header
- remove quotes from sender's json output to go along with
  dapr/quickstarts#621

Signed-off-by: Doug Davis <dug@microsoft.com>

* reorder pub-sub too

Signed-off-by: Doug Davis <dug@microsoft.com>

* add steps and uppercase Quickstart

Signed-off-by: Doug Davis <dug@microsoft.com>
* Add state management quickstart

* Address feedback on state-management quickstart

* Add link to sample GitHub repo
Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com>

* Add changes from the Python section to the rest of the languages for consistency.
Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com>

* Update state management image, capitlize Quickstart and add client initiation code to Javascript, go, Python and C#.
Signed-off-by: Nir Mashkowski <nimashkowski@microsoft.com>

* Update statemanagement-quickstart.md

Updated the overview paragraph

* Update daprdocs/content/en/getting-started/quickstarts/_index.md

* Update daprdocs/content/en/getting-started/quickstarts/_index.md

* Update daprdocs/content/en/getting-started/quickstarts/_index.md

Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
* feature: add routerchecker in middleware

Signed-off-by: 1046102779 <seachen@tencent.com>

* feature: add routerchecker in middleware

Signed-off-by: 1046102779 <seachen@tencent.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
In the following example, spring-boot http port is 9001.
https://github.com/dapr/quickstarts/blob/master/service_invocation/java/http/order-processor/src/main/resources/application.properties

However, this tutorial's app-port is 6001.

Signed-off-by: Yusuke Tobo <46416479+YusukeTobo@users.noreply.github.com>
@YusukeTobo YusukeTobo requested review from a team as code owners June 19, 2022 00:31
@YusukeTobo YusukeTobo changed the base branch from v1.6 to v1.7 June 19, 2022 00:37
@YusukeTobo YusukeTobo closed this Jun 19, 2022
@YusukeTobo
Copy link
Author

YusukeTobo commented Jun 19, 2022

Sorry if I interrupt you. I should have read this document, and followed the requirement..
Read the contribution guide
Overall, all updates should go into the docs branch for the latest release of Dapr.

I tried to rebase it to current default branch v1.7, but that included a lot of commits that are not by me. So, I closed this PR by myself..
Once I carefully read the guide, I'll make another PR for fixing the wrong port in doc.

@YusukeTobo YusukeTobo deleted the patch-1 branch June 19, 2022 01:05
@YusukeTobo
Copy link
Author

YusukeTobo commented Jun 19, 2022

I realized there are the same PR to v1.7 there and the port had fixed already for v1.7 doc. Again sorry for my misunderstanding.
#2491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.