Skip to content

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Sep 11, 2025

Add complex scenario and explanation and fix other image to use 'child' instead of 'suborchestrator'.

@cicoyle cicoyle requested review from a team as code owners September 11, 2025 17:53
@cicoyle
Copy link
Contributor Author

cicoyle commented Sep 11, 2025

Im running into issues running the hugo server locally even without my changes in this PR:

$ npm install       

up to date, audited 219 packages in 563ms

64 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


$ hugo server
WARN  Module "github.com/dapr/docs" is not compatible with this Hugo version: Min 0.146.0 extended; run "hugo mod graph" for more information.
WARN  Module "github.com/google/docsy" is not compatible with this Hugo version: Min 0.146.0 extended; run "hugo mod graph" for more information.
Watching for changes in /Users/cassie/go/src/github.com/docs/{daprdocs,package.json,sdkdocs,translations}
Watching for config changes in /Users/cassie/go/src/github.com/docs/hugo.yaml, /Users/cassie/go/src/github.com/docs/go.mod
Start building sites … 
hugo v0.146.0 darwin/arm64 BuildDate=unknown

Built in 420 ms
Error: error building site: process: readAndProcessContent: "/Users/cassie/go/src/github.com/docs/translations/docs-zh/translated_content/zh_CN/docs/developing-applications/building-blocks/actors/actor-reentrancy.md:32:1": failed to extract shortcode: template for shortcode "tabs" not found

@cicoyle cicoyle changed the title Multi-app workflows: improve docs Multi-app workflows: improve docs and images Sep 11, 2025
@cicoyle
Copy link
Contributor Author

cicoyle commented Sep 11, 2025

Just figured it out - Had to prune all my local submodules and update them. got it :thumb

@cicoyle
Copy link
Contributor Author

cicoyle commented Sep 11, 2025

I will need to resolve conflicts once this PR is merged

Im updating TestWorkflow to be BusinessWorkflow and all test refs to be 'business'

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cicoyle Looking good. Left a few comments

@msfussell
Copy link
Member

Also @cicoyle - Merged #4874 so you will have to resolve conflicts

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle force-pushed the fix-multi-app-wf-images branch from 56f1063 to 44e2756 Compare September 12, 2025 14:32
cicoyle and others added 2 commits September 12, 2025 09:35
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle
Copy link
Contributor Author

cicoyle commented Sep 12, 2025

@msfussell - all conflicts are resolved and feedback has been incorporated 👍🏻

@msfussell msfussell assigned msfussell and cicoyle and unassigned msfussell Sep 12, 2025
@msfussell
Copy link
Member

@marcduiker - Is going to update the images with the dapr theme to be consistent

@marcduiker
Copy link
Contributor

@cicoyle can you update the PR with these images?

workflow-multi-app-child-workflow.png
workflow-multi-app-child-workflow

workflow-multi-app-complex.png
workflow-multi-app-complex

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 1e03ece into dapr:v1.16 Sep 16, 2025
4 checks passed
MyMirelHub pushed a commit to MyMirelHub/docs that referenced this pull request Sep 19, 2025
* add complex wf illustration and fix other image

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* cleanup

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update howto author wfs

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update go code to use vanity client

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* Apply suggestions from code review

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>

* add scheduleworkflow note

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* update images

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants