-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ActorReference creation from the ActorBase class informations #1277
Added ActorReference creation from the ActorBase class informations #1277
Conversation
b37f235
to
c68209e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 67.28% 67.55% +0.26%
==========================================
Files 174 174
Lines 6025 6041 +16
Branches 671 671
==========================================
+ Hits 4054 4081 +27
+ Misses 1802 1790 -12
- Partials 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
40067d4
to
a03a213
Compare
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…rtible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
a03a213
to
98497a7
Compare
@philliphoff Another transient error seems to have appeared in actions. Is there a command that can be given to re-execute actions? Recorded error in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @m3nax. Just need to resolve the merge conflict and it can be committed.
@philliphoff Done |
@philliphoff can be included in v1.14 milestone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
* Samples - Add k8s deployment yaml to DemoActor sample (#1308) * up Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed build Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added scripts for image build Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added readme Build and push Docker image Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added demo-actor.yaml Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed typo Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated guide, fixed invocation throw curl Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Removed dockerfile, updated readme, removed ps1 and sh scripts Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated base image Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Update demo-actor.yaml Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added overload for DaprClient DI registration (#1289) * Added overload for DaprClient DI registration allowing the consumer to easily use values from injected services (e.g. IConfiguration). Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added supporting unit test Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Merge `release-1.13` back into `master` (#1285) * Update protos and related use for Dapr 1.13. (#1236) * Update protos and related use. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr runtime version. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Init properties. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update artifact action versions. (#1240) Signed-off-by: Phillip Hoff <phillip@orst.edu> * Make recursive true as default (#1243) Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Fix for secret key transformation in multi-value scenarios (#1274) * Add repro test. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Fix for secret key transformation in multi-value scenarios. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr version numbers used during testing. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Aligned nuget version Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * UP Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * UP Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Debug profile added Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Emitted DAPR001 Diagnostic warning Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added DAPR002 diagnostic Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Cleaun Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * UP Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added summaries Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added base interface to ActorClient Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added ctor Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added nullable directive Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added null check for actorproxy ctor parameter Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Moved DiagnoticException in a dedicate cs file Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Moved generator costants to dedicated class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added ActorReference creation from the ActorBase class informations (#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added overload to support SDK supplying query string on invoked URL (#1310) * Refactored extensions and their tests into separate directories Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added overload to method invocation to allow query string parameters to be passed in via the SDK instead of being uncermoniously added to the end of the produced HttpRequestMessage URI Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added unit tests to support implementation Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Marking HttpExtensions as internal to prevent external usage and updating to work against Uri instead of HttpRequestMessage. Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated unit tests to match new extension purpose Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Resolved an ambiguous method invocation wherein it was taking the query string and passing it as the payload for a request. Removed the offending method and reworked the remaining configurations so there's no API impact. Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed actorProxy argument null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Moved ActorClientDesciptor into separta cs file Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Moved textual templates to dedicated class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated comments, property names Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added argument null check to SyntaxFactoryHelpers Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added comments Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Removed obsolete testing packages https://github.com/dotnet/roslyn-sdk/blob/main/src/Microsoft.CodeAnalysis.Testing/README.md#obsolete-packages Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Adapted existing unit test to new source generated code Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Up Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added tests for SyntaxFactoryHelpers Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated generation of ArgumentNullException Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated nullability Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed internal methods tests Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test to IEnumerableExtensions Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Unittested GetSyntaxKinds from Accessibility Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * UP Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated assignment implementation of ctor body Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Improved unit test Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added implementation of method generation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed ArgumentNullException invocation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for NameOfExpression Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed ActorProxy method invocation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Simplified proxy argument definition Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Explicit generic arguments of the proxy call during generation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Handled cancellation token with default value Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed typo Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Configured eol used in NormalizeWhitespace function Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Normalized expected source Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Moved to constat the ActorProxyTypeName Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fix typo Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Created ActorProxyInvokeMethodAsync SyntaxFactoryHelper Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Removed custom concat implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * fix (#1329) Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * link to non-dapr endpoint howto (#1335) Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Merge 1.14 release branch back into `master`. (#1337) Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed merge errors Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated some summaries Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added some missing summaries Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed typo Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Improved some summary text Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Improved summaries Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Handled review requests Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Changed SyntaxFactoryHelpers accessor to internal Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Description
// TODO check for ActorBase
in the code of ActorReference class.Example:
Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: