Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 184 #185

Merged
merged 8 commits into from
Dec 13, 2019
Merged

Issue 184 #185

merged 8 commits into from
Dec 13, 2019

Conversation

jeastham1993
Copy link
Contributor

Description

Added a HttpClient implementation of the Dapr invoke endpoints following the same pattern as the StateClient.

Issue reference

This issue is related to issue #184

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@msftclas
Copy link

msftclas commented Dec 11, 2019

CLA assistant check
All CLA requirements met.

src/Dapr.Client/InvokeHttpClient.cs Outdated Show resolved Hide resolved
src/Dapr.Client/InvokeHttpClient.cs Outdated Show resolved Hide resolved
src/Dapr.Client/InvokeHttpClient.cs Outdated Show resolved Hide resolved
src/Dapr.Client/InvokeHttpClient.cs Show resolved Hide resolved
@amanbha
Copy link
Contributor

amanbha commented Dec 13, 2019

Thanks @jeastham1993 for the contribution, this looks good. I see that you have added unit tests which is great. Have you validated it with invoking another service using Dapr.

@jeastham1993
Copy link
Contributor Author

Happy to help @amanbha . I can go through and add clients for the other endpoints as well if you like?

Yep, I built an application locally against my service and invoked a method using the API calls. All seems good to me 👍

@amanbha
Copy link
Contributor

amanbha commented Dec 13, 2019

Happy to help @amanbha . I can go through and add clients for the other endpoints as well if you like?

Yep, I built an application locally against my service and invoked a method using the API calls. All seems good to me 👍

Thats great, I will merge this. Yes, your other contributions to the project are welcome too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants