Make sure IllegalArgumentException is thrown when Null value is being set for setRetryTimeout #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
|
@cicoyle , @salaboy , @artur-ciocanu Can you folks please take a look at this PR please ? |
This was referenced May 13, 2025
Merged
|
@siri-varma this looks good to me, so basically we were hitting an edge case when the retryTimeout was not set.. this makes sense.. Thanks for clarifying that in the other other issue too. |
cicoyle
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
dapr/java-sdk#1342
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information