Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata support for PublishEvent API #164

Closed
ravi-k4 opened this issue May 4, 2021 · 1 comment · Fixed by #179
Closed

Add metadata support for PublishEvent API #164

ravi-k4 opened this issue May 4, 2021 · 1 comment · Fixed by #179
Assignees
@ravi-k4
Labels
enhancement New feature or request P1
Milestone
1.3

Comments

@ravi-k4
Copy link

ravi-k4 commented May 4, 2021

Is your feature request related to a problem? Please describe.
I cannot set the partition key for Kafka without metadata support in PublishEvent API .

Describe the solution you'd like
Add extra argument "metadata" of type map[string]string to this API and so that it can be set in PublishEventRequest at https://github.com/dapr/go-sdk/blob/main/client/pubsub.go#L20
@ravi-k4 ravi-k4 added the enhancement New feature or request label May 4, 2021
@berndverst berndverst added the P1 label Jun 9, 2021
@berndverst berndverst added this to the 1.2 milestone Jun 9, 2021
ItalyPaleAle added a commit to ItalyPaleAle/dapr-go-sdk that referenced this issue Jun 15, 2021
@ItalyPaleAle
Added PublishEventWithMetadata
b38053f 
Fixes dapr#164
@ItalyPaleAle ItalyPaleAle mentioned this issue Jun 15, 2021
Closed
@berndverst
Copy link
Member

This will also make it possible to set TTL for PubSub.

https://docs.dapr.io/developing-applications/building-blocks/pubsub/pubsub-message-ttl/

@ItalyPaleAle ItalyPaleAle mentioned this issue Jun 16, 2021
Closed
ItalyPaleAle added a commit to ItalyPaleAle/dapr-go-sdk that referenced this issue Jun 19, 2021
@ItalyPaleAle
Rationalize PublishEvent* APIs
2970358 
Allow passing options such as Content-Type and Metadata in a flexible and future-proof way.
The method `PublishEventfromCustomContent` is now deprecated and shows a warning in the console when used.
Fixes dapr#174, dapr#164
@ItalyPaleAle ItalyPaleAle mentioned this issue Jun 19, 2021
Merged
@yaron2 yaron2 modified the milestones: 1.2, 1.3 Jul 1, 2021
@ItalyPaleAle ItalyPaleAle mentioned this issue Jul 9, 2021
Closed
yaron2 added a commit that referenced this issue Oct 7, 2021
@ItalyPaleAle @yaron2 @pkedy
Rationalize PublishEvent* APIs (#179)
9fceff8 
* Rationalize PublishEvent* APIs
Allow passing options such as Content-Type and Metadata in a flexible and future-proof way.
The method `PublishEventfromCustomContent` is now deprecated and shows a warning in the console when used.
Fixes #174, #164

* Do not wrap errors for invocations
Fix #186

* Updated variable name

* Added error check

* Oops

* Linting

Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Co-authored-by: Phil Kedy <phil.kedy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravi-k4 ravi-k4

Labels
enhancement New feature or request P1
Projects
None yet
Milestone
1.3
3 participants
@berndverst @yaron2 @ravi-k4