-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PublishEventWithMetadata #173
Conversation
LGTM If you are looking for other contributions related to this:
|
@yaron2 can you please review this PR also and merge if it looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @ItalyPaleAle !
@yaron2 as I was talking to Bernd yesterday over Teams, while this PR does fix 164 perhaps there may be a better approach with what I proposed in 174. Can you take a look and let me know if I should scrap this PR? If you prefer the approach in 174, i should be able to make a new PR fairly quickly. |
Thanks for taking a look at this, I agree that this can be done in a different way. Please see my comment here: #174 (comment). I'm closing this PR for now, we can re-open if needed. |
Fixes #164